Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote_receiver, remote_transmitter] Improve error messages on the ESP32 #6701

Merged
merged 2 commits into from
May 8, 2024

Conversation

Mat931
Copy link
Contributor

@Mat931 Mat931 commented May 8, 2024

What does this implement/fix?

When a RMT channel is already in use the error message doesn't tell the user what's wrong.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.18%. Comparing base (4d8b5ed) to head (8d2678a).
Report is 537 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6701      +/-   ##
==========================================
+ Coverage   53.70%   54.18%   +0.47%     
==========================================
  Files          50       50              
  Lines        9408     9579     +171     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5190     +137     
- Misses       4056     4065       +9     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mat931 Mat931 marked this pull request as ready for review May 8, 2024 17:37
@jesserockz jesserockz added this to the 2024.5.0b2 milestone May 8, 2024
@jesserockz jesserockz merged commit 487e171 into esphome:dev May 8, 2024
78 checks passed
aodrenah pushed a commit to aodrenah/esphome that referenced this pull request May 8, 2024
@jesserockz jesserockz mentioned this pull request May 9, 2024
@Mat931 Mat931 deleted the rmt-improve-error-messages branch May 9, 2024 08:31
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants