Add support for INA226 Current/Power Monitor #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoWinter
reviewed
Oct 26, 2019
There was a problem hiding this comment.
Great work! The code here looks great!
You just need to fix some things to make the lint checks happy:
First, these clang-tidy issues: https://travis-ci.org/esphome/esphome/jobs/602906706#L859
Then, these clang-format issues: https://travis-ci.org/esphome/esphome/jobs/602906706#L896 (it looks like you have empty lines with spaces)
Last, this python formatting check: https://travis-ci.org/esphome/esphome/jobs/602906698#L367
added 2 commits
October 28, 2019 14:16
OttoWinter
approved these changes
Oct 30, 2019
2 tasks
OttoWinter
reviewed
Nov 5, 2019
OttoWinter
approved these changes
Nov 6, 2019
OttoWinter
added
component: sensor.ina226
has-tests
integration: ina226
and removed
component: sensor.ina226
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
INA226 is a current shunt and power monitor with an I2C or SMBus compatible interface. The device monitors both a shunt voltage drop and bus supply voltage.
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#403
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: