Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dump/tx of 64 bit codes #940

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Fix dump/tx of 64 bit codes #940

merged 2 commits into from
Jan 12, 2020

Conversation

andrasbiro
Copy link
Contributor

Description:

Related issue (if applicable):
fixes missed errors in #662
partially fixes esphome/feature-requests#283
KaKu bits are looking like this:
0: h, L, h, l
1: h, l, h, L
(h=high, l=low short, L=low long)
Now, rcswitch can't handle this, but it can handle (h, l) and (h, L) - this is exactly what protocol8 does in #662

Tx still won't work, I'll add a note in the ticket about the remaining problems.

Checklist:

  • The code change is tested and works locally. Tested with a coco remote and an intertechno relay (both seem to be variation of kaku)
  • Tests have been added to verify that the new code works (under tests/ folder).

@depen84
Copy link

depen84 commented Jan 6, 2020

KaKu and Nexa is partly compatible and there is a PR to implement Nexa codes:
#662

@andrasbiro
Copy link
Contributor Author

I know, I mentioned it above. However, because of the bug in dump, it wasn't really possible to use it, unless you know the code from some other source. That is fixed in this PR.

Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks!

@OttoWinter OttoWinter merged commit a30d2f2 into esphome:dev Jan 12, 2020
@lock lock bot locked and limited conversation to collaborators Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for KlikAnKlikUt (KaKu) RF433 Switches
3 participants