Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth advertising automation #995

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Bluetooth advertising automation #995

merged 4 commits into from
Apr 27, 2020

Conversation

puuu
Copy link
Contributor

@puuu puuu commented Mar 12, 2020 •
edited
Loading

Description:

Add automations that trigger on Bluetooth advertising messages:

  • raw advertising message
  • service data advertising message
  • manufacturer data advertise message

Related issue (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#512

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@brandond
Copy link
Collaborator

It looks like the resulting test2 firmware is too large. Can you try moving the tests to another yaml?

@puuu
Copy link
Contributor Author

puuu commented Mar 12, 2020

The esp32_ble_tracker component is only in test2. The last commit removes deep_sleep from test2 to make test2 successful. However, we need a better solution, as the next change related to esp32_ble_tracker will hit the same problem.

@puuu puuu mentioned this pull request Mar 17, 2020
Merged
1 task
@jzlka
Copy link
Contributor

jzlka commented Apr 10, 2020

@puuu Hey, I've just had the same problem in my PR as well. I moved some tests to test3.yaml too, hopefully, I did not break anything.

@glmnet
Copy link
Member

glmnet commented Apr 25, 2020 •
edited
Loading

LGTM docs too

@glmnet glmnet merged commit ba1222e into esphome:dev Apr 27, 2020
schmart pushed a commit to schmart/esphome that referenced this pull request Apr 29, 2020
@puuu @schmart
Bluetooth advertising automation (esphome#995)
5874738 
* esp32_ble_tracker: introduce UUID comparison function

* ble_presence, ble_rssi: use new UUID comparison function

* esp32_ble_tracker: introduce automation on BLE advertising

* test2.yaml: remove deep_sleep due to firmware size restrictions
@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
core has-tests integration: ble_presence integration: ble_rssi integration: esp32_ble_tracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@puuu @brandond @jzlka @glmnet @OttoWinter