Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format TidalFlow2ACO in tutorials and create .rst #13

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Conversation

hunjhunj
Copy link
Contributor

No description provided.

@elbeejay elbeejay self-assigned this Aug 19, 2020
Sediment erosion and Transport from
===================================

In this notebook we implement the erosion and sediment transport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only erosion - no sediment transport. It assumes infinite amount of sediment in each cell, and only calcs. vertical erosion (we didn't have time to calc. the rest).

Copy link
Contributor

@ale37911 ale37911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making some comments on write up - thanks for starting this!

@elbeejay
Copy link
Member

elbeejay commented Aug 19, 2020

@ale37911 It is likely going to be easier for @hunjhunj to make your edits in her local notebook and re-building the .rst file so that the changes are reflected in both the .ipynb and on the rendered version. @ale37911 are you okay with merging as-is for now and doing another PR with corrections?

@ale37911
Copy link
Contributor

Sure happy to do that - I'm playing with the notebook this morning a bit to see if I can track down error in computation of erosion...

@elbeejay elbeejay merged commit c08a93c into master Aug 19, 2020
@elbeejay elbeejay mentioned this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants