Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling nonlinear activation of the last encoder layer #1323

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

simpleoier
Copy link
Collaborator

No description provided.

@simpleoier
Copy link
Collaborator Author

Relating to #1304

@sw005320
Copy link
Contributor

Thanks.
Can you also update RESULTS.md in some recipes that you tried?

@sw005320 sw005320 added this to the v.0.5.5 milestone Oct 30, 2019
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #1323 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   78.38%   78.38%   +<.01%     
==========================================
  Files         103      103              
  Lines       10067    10069       +2     
==========================================
+ Hits         7891     7893       +2     
  Misses       2176     2176
Impacted Files Coverage Δ
espnet/nets/pytorch_backend/rnn/encoders.py 97.81% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7ed9b...c18017e. Read the comment docs.

@simpleoier
Copy link
Collaborator Author

I didn't update the results of an4, because my numbers are worse than the ones in RESULT.

@sw005320
Copy link
Contributor

It's OK. Thanks a lot!

@sw005320 sw005320 merged commit aa03439 into espnet:master Oct 30, 2019
@simpleoier simpleoier deleted the enc_act_fix branch May 6, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants