Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libri_trans asr recipe #1344

Merged
merged 7 commits into from
Nov 12, 2019

Conversation

hirofumi0810
Copy link
Collaborator

  • Change RNN to Transformer
  • Change character unit to BPE1k unit

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #1344 into v.0.6.0 will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v.0.6.0    #1344      +/-   ##
===========================================
+ Coverage    77.45%   77.69%   +0.23%     
===========================================
  Files          110      110              
  Lines        10541    10776     +235     
===========================================
+ Hits          8165     8372     +207     
- Misses        2376     2404      +28
Impacted Files Coverage Δ
espnet/nets/pytorch_backend/streaming/segment.py 60.6% <0%> (-2.3%) ⬇️
espnet/nets/pytorch_backend/e2e_tts_fastspeech.py 95.03% <0%> (-0.21%) ⬇️
espnet/nets/pytorch_backend/e2e_tts_transformer.py 89.58% <0%> (+0.18%) ⬆️
espnet/nets/pytorch_backend/rnn/encoders.py 98.34% <0%> (+0.53%) ⬆️
espnet/nets/pytorch_backend/e2e_asr_transducer.py 64.64% <0%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38b4b0...d9900d2. Read the comment docs.

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

  • please consider uploading the model.
  • what is the major difference between bpe and char transformer yaml files? Batchsize (due to the shorter output length with bpe?)? Can you add the comment to the yaml file?

@hirofumi0810
Copy link
Collaborator Author

@sw005320 I will update results with SpecAugment tomorrow.

@sw005320 sw005320 added this to the v.0.6.0 milestone Nov 12, 2019
@hirofumi0810
Copy link
Collaborator Author

@sw005320 Ready to be merged.

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!
The result is impressive.

@sw005320
Copy link
Contributor

LGTM

@sw005320 sw005320 merged commit 88abdf6 into espnet:v.0.6.0 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants