Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egs2/iwslt22_dialect #4013

Merged
merged 14 commits into from
Feb 8, 2022
Merged

egs2/iwslt22_dialect #4013

merged 14 commits into from
Feb 8, 2022

Conversation

brianyan918
Copy link
Contributor

@brianyan918 brianyan918 commented Jan 29, 2022

This PR is for the IWSLT22 Dialectal ST Track: https://iwslt.org/2022/dialect

The contents will include

  • ST data prep of Tunisian-Arabic to English triplet ST data
  • ST Baseline model recipes
  • ASR data prep and baseline recipes
  • Hugginface upload for st template

@mergify mergify bot added the ESPnet2 label Jan 29, 2022
@sw005320 sw005320 added Recipe ST Speech translation labels Jan 29, 2022
@sw005320 sw005320 added this to the v.0.10.6 milestone Jan 29, 2022
@sw005320 sw005320 requested a review from ftshijt January 29, 2022 18:07
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 29, 2022

Looks cool! Just to remind:

  1. please add an entry at egs2/README.md for the recipe
  2. recommend to have an asr recipe as well, pre-training seems to be very important in egs2 (for both transformer and conformer)

@brianyan918
Copy link
Contributor Author

brianyan918 commented Jan 29, 2022 via email

@ftshijt
Copy link
Collaborator

ftshijt commented Feb 2, 2022

Could you pull the latest master in espnet so as to fix the broken CI?

@sw005320
Copy link
Contributor

sw005320 commented Feb 6, 2022

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4013 (b719193) into master (18ca099) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4013   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files         435      435           
  Lines       37389    37392    +3     
=======================================
+ Hits        30259    30262    +3     
  Misses       7130     7130           
Flag Coverage Δ
test_integration_espnet1 67.24% <ø> (ø)
test_integration_espnet2 52.50% <100.00%> (+<0.01%) ⬆️
test_python 66.58% <100.00%> (+<0.01%) ⬆️
test_utils 24.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/bin/pack.py 95.55% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ca099...b719193. Read the comment docs.

@brianyan918
Copy link
Contributor Author

Sorry, I fail some CI's but I do not understand them.. @ftshijt can you help me?

@sw005320
Copy link
Contributor

sw005320 commented Feb 8, 2022

We have a CI issue in #4043, which is fixed now.
So, could you merge the master?

If it is ready for merge, can you remove WIP in the subject?

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please fix them according to my comments.

@kan-bayashi kan-bayashi modified the milestones: v.0.10.6, v.0.10.7 Feb 8, 2022
@brianyan918 brianyan918 changed the title [WIP] egs2/iwslt22_dialect egs2/iwslt22_dialect Feb 8, 2022
@sw005320 sw005320 merged commit ed7bfa0 into espnet:master Feb 8, 2022
@sw005320
Copy link
Contributor

sw005320 commented Feb 8, 2022

Thanks, @brianyan918!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESPnet2 Recipe ST Speech translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants