Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes in ST in espnet2 #4056

Merged
merged 8 commits into from
Feb 11, 2022
Merged

minor fixes in ST in espnet2 #4056

merged 8 commits into from
Feb 11, 2022

Conversation

siddalmia
Copy link
Contributor

This PR does some minor bug patches to the PRs - #3987 and #4013

  • the DB had some errors and redundancy.
  • st/espnet_model.py had errors in their logging.
  • egs2/iwslt22_dialect/asr1/run.sh asr config file path was wrong.
  • egs2/fisher_callhome_spanish/st1/run.sh is also broken. I am still working on this. @ftshijt would you like to have a look at this? I have sent you the error.

@mergify mergify bot added the ESPnet2 label Feb 10, 2022
@sw005320 sw005320 added this to the v.0.10.7 milestone Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #4056 (89a9be9) into master (527e093) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4056   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         435      435           
  Lines       37425    37425           
=======================================
  Hits        30294    30294           
  Misses       7131     7131           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 52.44% <ø> (ø)
test_python 66.61% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/st/espnet_model.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527e093...89a9be9. Read the comment docs.

@siddalmia
Copy link
Contributor Author

Hi @sw005320, please don't merge it yet. There are still a lot of broken files in the egs2/fisher_callhome_spanish I found both asr1 and st1 to be broken.

@mergify mergify bot added the ESPnet1 label Feb 11, 2022
@siddalmia
Copy link
Contributor Author

Ok ready to merge. @sw005320

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the fixing. I left some comments

egs2/fisher_callhome_spanish/asr1/local/data.sh Outdated Show resolved Hide resolved
egs2/fisher_callhome_spanish/asr1/local/data.sh Outdated Show resolved Hide resolved
egs2/fisher_callhome_spanish/asr1/local/divide_lang.sh Outdated Show resolved Hide resolved
egs2/fisher_callhome_spanish/asr1/local/mapping Outdated Show resolved Hide resolved
egs2/fisher_callhome_spanish/asr1/local/score_bleu.sh Outdated Show resolved Hide resolved
@siddalmia
Copy link
Contributor Author

@sw005320 @ftshijt ok I think we are ready to merge!

@ftshijt ftshijt merged commit ea66f3f into espnet:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants