-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor fixes in ST in espnet2 #4056
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4056 +/- ##
=======================================
Coverage 80.94% 80.94%
=======================================
Files 435 435
Lines 37425 37425
=======================================
Hits 30294 30294
Misses 7131 7131
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @sw005320, please don't merge it yet. There are still a lot of broken files in the |
Ok ready to merge. @sw005320 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the fixing. I left some comments
This PR does some minor bug patches to the PRs - #3987 and #4013
st/espnet_model.py
had errors in their logging.egs2/iwslt22_dialect/asr1/run.sh
asr config file path was wrong.egs2/fisher_callhome_spanish/st1/run.sh
is also broken. I am still working on this. @ftshijt would you like to have a look at this? I have sent you the error.