Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Add Custom Field of Type Array to Search Filter #17

Closed
alasdaircr opened this issue Oct 30, 2014 · 8 comments
Closed

Cannot Add Custom Field of Type Array to Search Filter #17

alasdaircr opened this issue Oct 30, 2014 · 8 comments

Comments

@alasdaircr
Copy link
Contributor

reported here: http://forum.espocrm.com/bug-reports/2913-cannot-add-custom-field-of-type-array-to-search-filter?routestring=forum/bug-reports/2913-cannot-add-custom-field-of-type-array-to-search-filter

Leaving this as placeholder as I need this and so will make up a PR

@yurikuzn
Copy link
Contributor

How are you going to convert list of items into SQL expression?

@alasdaircr
Copy link
Contributor Author

Not sure. Do have any ideas?

@yurikuzn
Copy link
Contributor

To create complex expression like

(field_name LIKE '%'{VALUE_1}'%') OR (field_name LIKE '%'{VALUE_2}'%')

This looks bit hard coded.

P.S. I think it should be coded in Base SearchManager.

@alasdaircr
Copy link
Contributor Author

Not really hard coded though as it's a generated query from the search parameters.

@alasdaircr
Copy link
Contributor Author

Also doesn't need % fuzzy search as the parameters to the query come from the field declaration, so 100% match only

@alasdaircr
Copy link
Contributor Author

Hmm forget that last comment :)

@alasdaircr
Copy link
Contributor Author

But anyway, this feature should be there, even if not perfect. The field type is allowed, so searching MUST be allowed otherwise it's pretty useless.

alasdaircr pushed a commit to alasdaircr/espocrm that referenced this issue Nov 24, 2014
alasdaircr pushed a commit to alasdaircr/espocrm that referenced this issue Jan 6, 2015
@alasdaircr
Copy link
Contributor Author

Sent pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants