Added overload on send to cleanly handle char arrays in WebServer #6721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Multiple issues have been opened about users having strings "disappear" on send. This seem to be caused by feeding WebServer::send() a char array. This gets cast into a const String, and if the size exceeds the maximum possible allocation, there is a silent fail and an empty String gets sent out. While not truly a fix, this will raise an error message if the String allocation fails.
Tests scenarios
Tested on esp32-c3 dev board, current master, but seems very generalized.
Related links
Fixes #6704