Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3 #7410

Baptou88 · 2022-10-30T10:56:01Z

Changes to be committed:
new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h
new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h
Source: https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series/tree/master/esp32/variants

Changes to be committed: new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h

CLAassistant · 2022-10-30T10:56:05Z

All committers have signed the CLA.

P-R-O-C-H-Y · 2022-11-02T11:20:24Z

@Baptou88 The new boards are missing in our boards.txt file and has to be added if needed. So adding this is useless without that. If you want these boards in Arduino-esp32 feel free to add them to the boards.txt. After that I will review the changes.

Changes to be committed: new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h modified: boards.txt

Baptou88 · 2022-11-02T15:34:10Z

thanks @P-R-O-C-H-Y for your reply! I've modified board.txt, I hope it will be good

P-R-O-C-H-Y · 2022-11-03T10:33:10Z

@Baptou88 Overall looks good, but as the previous HELTEC boards already existing in our boards.txt can you please add the "heltec" at the start of the name? Will make more sense better :)

Baptou88 · 2022-11-03T11:46:51Z

@P-R-O-C-H-Y I just fixed boards.txt file

P-R-O-C-H-Y

@Baptou88 PTAL on my comments. After changes please try to compile with the boards to be sure its working 👍

boards.txt

P-R-O-C-H-Y · 2022-11-04T08:36:39Z

boards.txt

+heltec_wifi_lora_V3.upload.tool.default=esptool_py
+heltec_wifi_lora_V3.upload.tool.network=esp_ota
+
+heltec_wifi_lora_V3.upload.maximum_size=1310720


Same here. When partition is fixed to default_8MB, I can't see that upload.maximus_size corresponds to the partition default_8MB.

esp32s3.menu.PartitionScheme.default_8MB.upload.maximum_size=3342336

boards.txt

P-R-O-C-H-Y · 2022-11-04T08:39:15Z

variants/heltec_wifi_kit_32_v3/pins_arduino.h

+static const uint8_t SCL_OLED = 18;
+static const uint8_t SDA_OLED = 17;
+
+#endif /* Pins_Arduino_h */


Please add new line at the end of the file to keep standart formatting.

P-R-O-C-H-Y · 2022-11-04T08:39:24Z

variants/heltec_wifi_lora_32_V3/pins_arduino.h

+static const uint8_t RST_OLED = 21;
+static const uint8_t SCL_OLED = 18;
+static const uint8_t SDA_OLED = 17;
+#endif /* Pins_Arduino_h */


Please add new line at the end of the file to keep standart formatting.

Add line after #endif /* Pins_Arduino_h */. So there will be empty line number 83.

boards.txt

Baptou88 · 2022-11-04T16:00:22Z

I'm testing the changes I made: here's what I did:

I created a platformio project configured this way:

[env:heltec_wifi_kit_32_V3]
platform = C:\Users\Baptou88\Documents\GitHub\platform-espressif32
board = heltec_wifi_kit_32_V3
framework = arduino
platform_packages = framework-arduinoespressif32 @ C:/Users/Baptou88/Documents/GitHub/arduino-esp32

[env:heltec_wifi_lora_32_V3]
platform = C:\Users\Baptou88\Documents\GitHub\platform-espressif32
board = heltec_wifi_lora_32_V3
framework = arduino
platform_packages = framework-arduinoespressif32 @ symlink://C:/Users/Baptou88/Documents/GitHub/arduino-esp32

I've use the command 'Build ALL' with this result:

Successfully created esp32s3 image.
====================================================================== [SUCCESS] Took 10.41 seconds ======================================================================

Environment             Status    Duration
----------------------  --------  ------------
heltec_wifi_kit_32_V3   SUCCESS   00:00:12.342
heltec_wifi_lora_32_V3  SUCCESS   00:00:10.411
====================================================================== 2 succeeded in 00:00:22.754 ======================================================================

I've upload a simple sketch =>it works
I've created a data folder in my project with a file in it, then i've use the command Upload FileSystem image : Works
I've used the commad "Erase Flash": Works

P-R-O-C-H-Y · 2022-11-07T08:42:39Z

I'm testing the changes I made: here's what I did:

I created a platformio project configured this way:

[env:heltec_wifi_kit_32_V3]
platform = C:\Users\Baptou88\Documents\GitHub\platform-espressif32
board = heltec_wifi_kit_32_V3
framework = arduino
platform_packages = framework-arduinoespressif32 @ C:/Users/Baptou88/Documents/GitHub/arduino-esp32

[env:heltec_wifi_lora_32_V3]
platform = C:\Users\Baptou88\Documents\GitHub\platform-espressif32
board = heltec_wifi_lora_32_V3
framework = arduino
platform_packages = framework-arduinoespressif32 @ symlink://C:/Users/Baptou88/Documents/GitHub/arduino-esp32

I've use the command 'Build ALL' with this result:

Successfully created esp32s3 image.
====================================================================== [SUCCESS] Took 10.41 seconds ======================================================================

Environment             Status    Duration
----------------------  --------  ------------
heltec_wifi_kit_32_V3   SUCCESS   00:00:12.342
heltec_wifi_lora_32_V3  SUCCESS   00:00:10.411
====================================================================== 2 succeeded in 00:00:22.754 ======================================================================

I've upload a simple sketch =>it works
I've created a data folder in my project with a file in it, then i've use the command Upload FileSystem image : Works
I've used the commad "Erase Flash": Works

@Baptou88 Can you commit the changes so I can review again and do test?

P-R-O-C-H-Y · 2022-11-15T08:18:35Z

variants/heltec_wifi_lora_32_V3/pins_arduino.h

+static const uint8_t RST_OLED = 21;
+static const uint8_t SCL_OLED = 18;
+static const uint8_t SDA_OLED = 17;
+#endif /* Pins_Arduino_h */


Add line after #endif /* Pins_Arduino_h */. So there will be empty line number 83.

boards.txt

P-R-O-C-H-Y · 2022-12-02T14:24:22Z

@Baptou88 Any updates?

Baptou88 · 2022-12-08T17:06:12Z

I did not update this PR. I don't have the skills to do it right.
to make this PR I based myself on the manufacturer's deposit (the directory is not updated and the data does not seem reliable)

I don't understand what modification I have to make for it to be valid

Baptou88 · 2022-12-22T15:49:28Z

thank you for helping me @P-R-O-C-H-Y !
when this pr was approved, an update of this repository Heltec / wifi kit series was noticed after a very long absence resulting in some modifications, I will have to take the time to analyze the modifications to correct

P-R-O-C-H-Y · 2022-12-22T15:58:00Z

No problem @Baptou88 :) feel free to open new PR with the modifications.

dberlin · 2023-01-12T18:56:50Z

There are only two changes since the merge -
wireless stick v3 support was added (I'll try to get to this ni a bit)
The I2c pins on wifi_lora_32_v3 were changed.

I will create a PR for the latter right now since it's easy.

dberlin · 2023-01-12T19:00:26Z

The I2C pin change is now #7709

I'll get to the wireless stick add in a day or two.

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3

a683f8b

Changes to be committed: new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h

P-R-O-C-H-Y self-assigned this Nov 2, 2022

P-R-O-C-H-Y added the Type: 3rd party Boards label Nov 2, 2022

Baptou88 added 2 commits November 2, 2022 16:31

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3

5b6f399

Changes to be committed: new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h modified: boards.txt

Merge branch 'master' of https://github.com/Baptou88/arduino-esp32

92d134d

Baptou88 added 2 commits November 3, 2022 12:44

added heltec v3 boards

731575f

Merge branch 'master' of https://github.com/Baptou88/arduino-esp32

ee4e821

SuGlider and others added 3 commits November 3, 2022 09:45

Merge branch 'master' into master

d92ee5c

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3

88946ab

Merge branch 'master' of https://github.com/Baptou88/arduino-esp32

eb2ed23

P-R-O-C-H-Y requested changes Nov 4, 2022

View reviewed changes

Merge branch 'master' into master

5a26900

P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Nov 9, 2022

Baptou88 added 2 commits November 14, 2022 17:34

Added Support for Heltec Boards V3

cde294c

Merge branch 'master' of https://github.com/Baptou88/arduino-esp32

f91046e

P-R-O-C-H-Y requested changes Nov 15, 2022

View reviewed changes

Baptou88 added 2 commits December 17, 2022 16:37

change upload max size for HeltecV3

84dc091

Merge branch 'master' into master

2e5c203

P-R-O-C-H-Y approved these changes Dec 21, 2022

View reviewed changes

Merge branch 'master' into master

60c9c0b

P-R-O-C-H-Y merged commit e91efd4 into espressif:master Dec 21, 2022

platypii mentioned this pull request Feb 9, 2023

Pinout for Heltec_wifi_kit_32_v3 is incorrect #7737

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3 #7410

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3 #7410

Baptou88 commented Oct 30, 2022

CLAassistant commented Oct 30, 2022 •

edited

P-R-O-C-H-Y commented Nov 2, 2022 •

edited

Baptou88 commented Nov 2, 2022

P-R-O-C-H-Y commented Nov 3, 2022

Baptou88 commented Nov 3, 2022

P-R-O-C-H-Y left a comment •

edited

P-R-O-C-H-Y Nov 4, 2022

P-R-O-C-H-Y Nov 4, 2022

P-R-O-C-H-Y Nov 4, 2022

P-R-O-C-H-Y Nov 15, 2022

Baptou88 commented Nov 4, 2022

P-R-O-C-H-Y commented Nov 7, 2022

P-R-O-C-H-Y Nov 15, 2022

P-R-O-C-H-Y commented Dec 2, 2022

Baptou88 commented Dec 8, 2022

Baptou88 commented Dec 22, 2022

P-R-O-C-H-Y commented Dec 22, 2022

dberlin commented Jan 12, 2023

dberlin commented Jan 12, 2023

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3 #7410

Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3 #7410

Conversation

Baptou88 commented Oct 30, 2022

CLAassistant commented Oct 30, 2022 • edited

P-R-O-C-H-Y commented Nov 2, 2022 • edited

Baptou88 commented Nov 2, 2022

P-R-O-C-H-Y commented Nov 3, 2022

Baptou88 commented Nov 3, 2022

P-R-O-C-H-Y left a comment • edited

Choose a reason for hiding this comment

P-R-O-C-H-Y Nov 4, 2022

Choose a reason for hiding this comment

P-R-O-C-H-Y Nov 4, 2022

Choose a reason for hiding this comment

P-R-O-C-H-Y Nov 4, 2022

Choose a reason for hiding this comment

P-R-O-C-H-Y Nov 15, 2022

Choose a reason for hiding this comment

Baptou88 commented Nov 4, 2022

P-R-O-C-H-Y commented Nov 7, 2022

P-R-O-C-H-Y Nov 15, 2022

Choose a reason for hiding this comment

P-R-O-C-H-Y commented Dec 2, 2022

Baptou88 commented Dec 8, 2022

Baptou88 commented Dec 22, 2022

P-R-O-C-H-Y commented Dec 22, 2022

dberlin commented Jan 12, 2023

dberlin commented Jan 12, 2023

CLAassistant commented Oct 30, 2022 •

edited

P-R-O-C-H-Y commented Nov 2, 2022 •

edited

P-R-O-C-H-Y left a comment •

edited