Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert FlashStringHelper Macros #8147

Merged
merged 1 commit into from
May 3, 2023
Merged

Revert FlashStringHelper Macros #8147

merged 1 commit into from
May 3, 2023

Conversation

mrengineer7777
Copy link
Collaborator

Description of Change

Revert to previous definition of FPSTR and F macros.
Same as #8143. This PR targets master instead of 2.x branch.

Related links

Closes #8108

@mrengineer7777
BugFix FlashStringHelper Macros
629c7e3 
Revert to previous definition of `FPSTR` and `F` macros.
@mrengineer7777 mrengineer7777 marked this pull request as ready for review May 2, 2023 13:57
@mrengineer7777 mrengineer7777 added this to the 2.0.9 milestone May 2, 2023
@mrengineer7777 mrengineer7777 added the lib_test Run External Libraries Test label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

External libraries build test

Library ESP32 ESP32C3 ESP32S2 ESP32S3
Adafruit NeoPixel 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ArduinoBLE 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ N/A 1 ✅ -> 1 ✅
ESP32Servo 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ESPAsyncWebServer 3 ✅ 1 ⚠️ -> 3 ✅ 1 ⚠️ 4 ❌ -> 4 ❌ 3 ✅ 1 ⚠️ -> 3 ✅ 1 ⚠️ 3 ✅ 1 ⚠️ -> 3 ✅ 1 ⚠️
FastLED 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
IRremote 1 ⚠️ -> 1 ⚠️ 1 ❌ -> 1 ❌ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
MFRC522 1 ❌ -> 1 ✅ 1 ❌ -> 1 ✅ 1 ❌ -> 1 ✅ 1 ❌ -> 1 ✅
WS2812FX 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌

@mrengineer7777 mrengineer7777 mentioned this pull request May 2, 2023
Merged
@SuGlider SuGlider mentioned this pull request May 2, 2023
Merged
SuGlider
SuGlider approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Replicated with #8143 with a different branch for merging.

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request May 3, 2023
Closed
1 task
@me-no-dev me-no-dev merged commit 5c92a02 into espressif:master May 3, 2023
@mrengineer7777 mrengineer7777 deleted the Bugfix_FlashStringHelper_Macros2 branch May 3, 2023 17:44
This was referenced May 4, 2023
Merged
Merged
@Juerd Juerd mentioned this pull request May 7, 2023
Open
@laxtiz laxtiz mentioned this pull request Sep 17, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

Assignees
No one assigned
Labels
lib_test Run External Libraries Test
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.9
Development

Successfully merging this pull request may close these issues.

Compile error under 2.0.8 if library function explicitly returns const __FlashStringHelper * from F() macro
3 participants
@mrengineer7777 @SuGlider @me-no-dev