Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Adafruit boards #8897

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Update Adafruit boards #8897

merged 3 commits into from
Nov 21, 2023

Conversation

hathach
Copy link
Contributor

@hathach hathach commented Nov 17, 2023

Description of Change

Follow up to #8894. This PR update Adafruit boards in boards.txt as follows:

  • Add ZigbeeMode menu to all Adafruit boards to fix compile error with latest master 
    xtensa-esp32s3-elf-g++: warning: {build.zigbee_mode}: linker input file unused because linking not done
xtensa-esp32s3-elf-g++: error: {build.zigbee_mode}: linker input file not found: No such file or directory
exit status 1
  • remove all duplicated tinyuf2 partitions.csv (4/8/16 MB) in each variant/board and use the supported csv in tools/partitions
  • Add TinyUF2 4/8/16MB No OTA partition scheme for all Adafruit boards. Some user may find this useful to have 2x flash size for appliation should OTA is not needed

tinyuf-noota

Tests scenarios

Tested with latest master c4fd383 with follows boards

  • adafruit feather esp32s3 (4MB)
  • adafruit feather esp32s3 nopsram (8MB)
  • adafruit metro esp32s3 (16MB)

All seems to work well, switching partitions works.

@ladyada @brentru

@brentru
Copy link

brentru commented Nov 17, 2023

@hathach Tested working with an Adafruit FunHouse ESP32-S2 and WipperSnapper firmware (which previously wouldn't fit on the TinyUSB+OTA partition).

@brentru brentru mentioned this pull request Nov 17, 2023
Merged
5 tasks
@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review November 20, 2023 10:06
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Nov 20, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 21, 2023
lucasssvaz
lucasssvaz approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev merged commit eedae15 into espressif:master Nov 21, 2023
79 checks passed
@hathach
Copy link
Contributor Author

hathach commented Nov 22, 2023

thank you for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hathach @brentru @lucasssvaz @P-R-O-C-H-Y @me-no-dev @VojtechBartoska