Add support for the MotorGo Mini board #9269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
IMO it would be better to add it to the 3.0.0 version (master branch). |
|
@SwapnilPande Overall looks good, but as Lucas mentioned, to have the board available for new releases you should target master branch. Also as we are planning 2.0.15 release, you can leave this PR and open a new one targeting the master. |
P-R-O-C-H-Y
requested changes
Feb 21, 2024
There was a problem hiding this comment.
@SwapnilPande Just small fix needed. After that its ready to be merged to 2.X release branch.
|
Thanks for the quick review! Wanted to make sure I target the 3.0 and 2.0 releases, I'll submit a PR targeting master today as well. |
SwapnilPande
force-pushed
the
release/v2.x
branch
from
a3183ba
to
23c9d33
Compare
|
Went ahead and rebased on the latest commit as well :) |
lucasssvaz
requested changes
Feb 21, 2024
lucasssvaz
approved these changes
Feb 21, 2024
P-R-O-C-H-Y
approved these changes
Feb 22, 2024
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for MotorGo Mini 1 motor controller with ESP32-S3.
Description of Change
Adds a new variant for the MotorGo Mini with an onboard ESP32-S3. Updated boards.txt and created a new variants directory.
Tests scenarios
Tested the new variant with the Arduino-ESP32Core 2.0.14 running on the MotorGo Mini 1 board.
Related links
MotorGo Website