Skip to content

Commit

Permalink
Merge branch 'bugfix/update_disabling_hmac_jtag_method_v5.1' into 're…
Browse files Browse the repository at this point in the history
…lease/v5.1'

fix(esp_hw_support): update hmac toggle method due to discrepency in ROM code (v5.1)

See merge request espressif/esp-idf!29531
  • Loading branch information
AdityaHPatwardhan committed Mar 13, 2024
2 parents db2a037 + 8cb2aa4 commit b884b37
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions components/esp_hw_support/esp_hmac.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2015-2022 Espressif Systems (Shanghai) CO LTD
* SPDX-FileCopyrightText: 2015-2024 Espressif Systems (Shanghai) CO LTD
*
* SPDX-License-Identifier: Apache-2.0
*/
Expand Down Expand Up @@ -170,7 +170,7 @@ esp_err_t esp_hmac_jtag_enable(hmac_key_id_t key_id, const uint8_t *token)

ESP_LOGD(TAG, "HMAC computation in downstream mode is completed.");

ets_hmac_disable();
periph_module_disable(PERIPH_HMAC_MODULE);

esp_crypto_hmac_lock_release();

Expand All @@ -180,9 +180,9 @@ esp_err_t esp_hmac_jtag_enable(hmac_key_id_t key_id, const uint8_t *token)
esp_err_t esp_hmac_jtag_disable()
{
esp_crypto_hmac_lock_acquire();
ets_hmac_enable();
periph_module_enable(PERIPH_HMAC_MODULE);
REG_WRITE(HMAC_SET_INVALIDATE_JTAG_REG, 1);
ets_hmac_disable();
periph_module_disable(PERIPH_HMAC_MODULE);
esp_crypto_hmac_lock_release();

ESP_LOGD(TAG, "Invalidate JTAG result register. JTAG disabled.");
Expand Down Expand Up @@ -217,7 +217,6 @@ esp_err_t esp_hmac_calculate(hmac_key_id_t key_id,
} else {
return ESP_OK;
}

}

esp_err_t esp_hmac_jtag_enable(hmac_key_id_t key_id, const uint8_t *token)
Expand Down

0 comments on commit b884b37

Please sign in to comment.