Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu labels when generating sdkconfig.defaults with idf.py save-defconfig (IDFGH-8945) #10358

Closed
macksal opened this issue Dec 13, 2022 · 2 comments
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@macksal
Copy link

macksal commented Dec 13, 2022

Is your feature request related to a problem?

The addition of idf.py save-defconfig has been incredibly helpful in managing the sdkconfig.defaults file. However, the structure of the file as it is spit out just includes all non-default options without any grouping or labels. This makes the file a more difficult to quickly audit. This is particularly true when many non-default options are present, or for projects which include config options for component dependencies e.g. esp-camera.

Describe the solution you'd like.

Ideally, save-defconfig would write out the sdkconfig.defaults file and include the same group labels that are written to sdkconfig in the build process.

For example:

#
# Partition Table
#
CONFIG_PARTITION_TABLE_TWO_OTA=y
# end of Partition Table

If the file is modified manually, the tool could reorganise the options into appropriate sections in an opinionated way or just leave them as-is. The least opinionated way would be to add a flag to save-defconfig that would choose whether to add the group labels and reformat or leave the existing structure.

Describe alternatives you've considered.

No response

Additional context.

No response

@macksal macksal added the Type: Feature Request Feature request for IDF label Dec 13, 2022
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 13, 2022
@github-actions github-actions bot changed the title Add menu labels when generating sdkconfig.defaults with idf.py save-defconfig Add menu labels when generating sdkconfig.defaults with idf.py save-defconfig (IDFGH-8945) Dec 13, 2022
@dobairoland
Copy link
Collaborator

Thanks for the feedback and suggestion!

@KaeLL
Copy link
Contributor

KaeLL commented Dec 13, 2022

The least opinionated way would be to add a flag to save-defconfig that would choose whether to add the group labels and reformat or leave the existing structure.

+1 for this, as I love the uber minimalism in the current version, and I occasionally do some text processing on the file, which is made easier by the fact that it's so simple. So if this is to be introduced, it's better that it be optional.

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development Status: In Progress Work is in progress and removed Status: Opened Issue is new Status: Selected for Development Issue is selected for development labels Sep 7, 2023
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: In Progress Work is in progress labels Oct 4, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable Resolution: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed Resolution: NA Issue resolution is unavailable labels Oct 20, 2023
movsb pushed a commit to movsb/esp-idf that referenced this issue Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

5 participants