Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW#26189] lwip stack broken in master commit #2392

Closed
chegewara opened this issue Sep 8, 2018 · 9 comments
Closed

[TW#26189] lwip stack broken in master commit #2392

chegewara opened this issue Sep 8, 2018 · 9 comments

Comments

@chegewara
Copy link
Contributor

In file included from D:/msys32/home/imper/ble_test/components/cpp_utils/WiFi.cpp:25:0:
D:/msys32/home/imper/esp/esp-idf/components/lwip/lwip/src/include/lwip/dns.h:112:1: error: 'err_t' does not name a type
 err_t            dns_gethostbyname(const char *hostname, ip_addr_t *addr,
 ^
D:/msys32/home/imper/esp/esp-idf/components/lwip/lwip/src/include/lwip/dns.h:114:1: error: 'err_t' does not name a type
 err_t            dns_gethostbyname_addrtype(const char *hostname, ip_addr_t *addr,
 ^
@negativekelvin
Copy link
Contributor

These lines went missing

#if ESP_DNS
#include "lwip/err.h"
#endif

@igrr
Copy link
Member

igrr commented Sep 9, 2018

FWIW this include seems to be needed even without ESP_DNS. Will add.

@negativekelvin
Copy link
Contributor

Yep yarrick/lwip@5b459c1

@gregjesl
Copy link
Contributor

gregjesl commented Sep 9, 2018

sntp/sntp.h is not present in the new lwip submodule. Is this by design? The Azure IoT Hub Client (which we are using in our project) uses sntp.h.

In file included from C:/Users/[Removed]/Documents/GitHub/[Removed]/components/azure-iot-sdk-c/c-utility/pal/lwip/sntp_lwip.c:10:0:
C:/Users/[Removed]/Documents/GitHub/[Removed]/components/azure-iot-sdk-c/c-utility/pal/lwip/sntp_os.h:14:28: fatal error: apps/sntp/sntp.h: No such file or directory
compilation terminated.
make[1]: *** [/c/esp-idf/make/component_wrapper.mk:286: c-utility/pal/lwip/sntp_lwip.o] Error 1
make: *** [C:/esp-idf/make/project.mk:481: component-azure-iot-sdk-c-build] Error 2

@negativekelvin
Copy link
Contributor

#include "lwip/apps/sntp.h"

@gregjesl
Copy link
Contributor

gregjesl commented Sep 9, 2018

@negativekelvin Thank you. I've created a pull request for Azure (Azure/azure-c-shared-utility#184)

@igrr
Copy link
Member

igrr commented Sep 9, 2018

Will add an sntp/sntp.h compatibility header in IDF as well

@FayeY FayeY changed the title lwip stack broken in master commit [TW#26189] lwip stack broken in master commit Sep 12, 2018
@liuzfesp
Copy link
Contributor

@zhangyanjiao please help

@zhangyanjiaoesp
Copy link
Collaborator

@liuzfesp igrr has solved this problem.

@igrr igrr closed this as completed in f8750eb Sep 27, 2018
catalinio pushed a commit to catalinio/pycom-esp-idf that referenced this issue Jun 28, 2019
Before LwIP was moved into a submodule, sntp and esp_ping were
available as the following includes:

#include "apps/sntp/sntp.h"
#include "esp_ping.h"

This commit makes header files available at the old location, and adds
a deprecation warning for sntp.h.

Closes espressif/esp-idf#2392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants