DAC header isn't self contained (IDFGH-404)

[devsaurus]

Environment

• Development Kit: [none]
• Core (if using chip or module): [ESP32-Wrover]
• IDF version (git rev-parse --short HEAD to get the commit id.): 7313e39
• Development Env: [Make]
• Operating System: [openSuse]
• Power Supply: [USB]

Problem Description

The driver/dac.h header uses definitions for gpio but doesn't include driver/gpio.h.

Expected Behavior

The code below compiles without errors.

Actual Behavior

sdk/esp32-esp-idf/components/driver/include/driver/dac.h:43:53: error: unknown type name 'gpio_num_t'
 esp_err_t dac_pad_get_io_num(dac_channel_t channel, gpio_num_t *gpio_num);

Steps to repropduce

Compile the code below.

Code to reproduce this issue

#include "driver/dac.h"

void myfunction(int chn) {
  dac_output_enable( chn );
}

Other items if possible

As a workaround I have to include driver/gpio.h before the dac header file even though my source file doesn't use GPIO API.

[koobest]

hi, @devsaurus, thank you, we will update the dac.h.

[xiongyumail]

Is there any progress?

[pilnikov]

Autors, please add new line
#include "gpio.h"
and correct line 42

• • ESP_ERR_INVALID_ARG if channal not valid
    on
• • ESP_ERR_INVALID_ARG if channel not valid

[Nufflee]

Any progress on this? Seems like a very simple change.

Edit: oh, in fact looks like it was fixed on master but the fix is not appearing in v3.30300.190916 (using PlatformIO).

This issue should probably be closed here anyways.

[Alvin1Zhang]

Thanks for reporting, sorry for slow turnaround, fix is available 8357318, feel free to reopen.