Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TW#27193] convert_to_cmake does not work #2660

Closed
callalilychen opened this issue Nov 3, 2018 · 1 comment
Closed

[TW#27193] convert_to_cmake does not work #2660

callalilychen opened this issue Nov 3, 2018 · 1 comment

Comments

@callalilychen
Copy link
Contributor

esp-idf/tools/cmake/convert_to_cmake.py

Line 95 in 12b2268

make_vars["COMPONENT_ADD_INCLUDEDIRS"] = make_vars.get("COMPONENT_ADD_INCLUDEDIRS", "include")

produces the following error:

IndentationError: unexpected indent
@Alvin1Zhang Alvin1Zhang changed the title convert_to_cmake does not work [TW#27193] convert_to_cmake does not work Nov 4, 2018
@igrr
Copy link
Member

igrr commented Nov 22, 2018

Thanks for reporting this @callalilychen, fixed in f4cfca4.

@igrr igrr closed this as completed Nov 22, 2018
igrr pushed a commit that referenced this issue Dec 5, 2018
@mahavirj
tools/ci: add test case for convert_to_cmake script
a378579 
Following issue was already fixed with earlier commit-id f4cfca4
Here additional build test case is added and marking issue as closed.

Closes: #2660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@callalilychen @igrr