Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: HTTP client library to check the binary length read from stream matches the HTTP he (IDFGH-594) #3004

Closed
javicordon opened this issue Jan 29, 2019 · 0 comments
Closed

Feature request: HTTP client library to check the binary length read from stream matches the HTTP he (IDFGH-594) #3004

javicordon opened this issue Jan 29, 2019 · 0 comments

Comments

@javicordon
Copy link

Environment

  • Development Kit: ESP32-Wrover-Kit and ESP32-PICO-Kit
  • IDF version: v3.3-beta1-136-g97eecfa-dirty
  • Build System: Make
  • Compiler version: xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
  • Operating System: macOS
  • Power Supply: USB

Problem Description

Downloading firmware OTA via SSL using server certificates from a Hosting Server is working but when there is an Origin Response Timeout or Origin Keep-alive Timeout, in the middle of reading a http stream, this leads to a partial download of the binary requested, in consequence OTA failure. Current HTTP client library doesn't check the binary length matches the HTTP header. This would be a desirable feature to prevent OTA to continue update and retry in case binary size doesn't match HTTP header.

Expected Behavior

HTTP client library that checks the binary length read from http stream matches the HTTP header.

Other items if possible

Advised to be requested in a new issue #231
@Alvin1Zhang Alvin1Zhang changed the title Feature request: HTTP client library to check the binary length read from stream matches the HTTP header [TW#28580] Feature request: HTTP client library to check the binary length read from stream matches the HTTP header Jan 30, 2019
@projectgus projectgus changed the title [TW#28580] Feature request: HTTP client library to check the binary length read from stream matches the HTTP header Feature request: HTTP client library to check the binary length read from stream matches the HTTP he (IDFGH-594) Mar 12, 2019
@igrr igrr closed this as completed in d4091f7 Aug 5, 2019
trombik pushed a commit to trombik/esp-idf that referenced this issue Aug 9, 2019
@hpdhabe @trombik
esp_http_client: Add support to check the binary length of the reciev…
f14d210 
…ed stream and compare it with the size mentioned in the header.

While downloading OTA firmware, if their is a Origin Respnse Timeout or the binary is only partially downloaded, OTA failure is observed. Checking binary size can also be helpful for simple http client applications.

Closes espressif#3004
espressif-bot pushed a commit that referenced this issue Jan 24, 2020
@hpdhabe @shubhamkulkarni97
esp_http_client: Add support to check the binary length of the reciev…
012ff57 
…ed stream and compare it with the size mentioned in the header.

While downloading OTA firmware, if their is a Origin Respnse Timeout or the binary is only partially downloaded, OTA failure is observed. Checking binary size can also be helpful for simple http client applications.

Closes #3004
espressif-bot pushed a commit that referenced this issue Mar 23, 2020
@hpdhabe @espressif-bot
esp_http_client: Add support to check the binary length of the reciev…
be08f6f 
…ed stream and compare it with the size mentioned in the header.

While downloading OTA firmware, if their is a Origin Respnse Timeout or the binary is only partially downloaded, OTA failure is observed. Checking binary size can also be helpful for simple http client applications.

Closes #3004
jack0c pushed a commit that referenced this issue Jul 29, 2020
@hpdhabe @jason-mao
esp_http_client: Add support to check the binary length of the reciev…
97aeb75 
…ed stream and compare it with the size mentioned in the header.

While downloading OTA firmware, if their is a Origin Respnse Timeout or the binary is only partially downloaded, OTA failure is observed. Checking binary size can also be helpful for simple http client applications.

Closes #3004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javicordon