Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling "Support ESP32 internal EMAC controller" breaks build (IDFGH-1504) #3770

Closed
nifomorph opened this issue Jul 11, 2019 · 1 comment
Closed
Assignees

Comments

@nifomorph
Copy link
Contributor

Environment

  • Development Kit: none
  • Module or chip used: ESP32
  • IDF version: v4.0-dev-1195-g38b7744
  • Build System: Make
  • Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp32-2019r1) 8.2.0
  • Operating System: macOS
  • Power Supply: USB

Problem Description

Disabling "Support ESP32 internal EMAC controller" breaks build.

Expected Behavior

ESP-IDF should compile with valid options set in menuconfig.

Actual Behavior

Build stops on undefined symbols in components/soc/esp32/emac_hal.c

Steps to reproduce

  1. make menuconfig
  2. De-select Component config-->Ethernet-->Support ESP32 internal EMAC controller
  3. make all

Code to reproduce this issue

Any esp-idf based project

Debug Logs

N/A

Other items if possible

Excerpt from build log:

CC build/bootloader/soc/esp32/emac_hal.o
/Users/nif/Documents/esp/esp-idf/components/soc/esp32/emac_hal.c: In function 'emac_hal_reset_desc_chain':
/Users/nif/Documents/esp/esp-idf/components/soc/esp32/emac_hal.c:141:54: error: 'CONFIG_ETH_DMA_RX_BUFFER_NUM' undeclared (first use in this function); did you mean 'CONFIG_ESP32_WIFI_TX_BUFFER_TYPE'?
                    sizeof(eth_dma_rx_descriptor_t) * CONFIG_ETH_DMA_RX_BUFFER_NUM);
                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                      CONFIG_ESP32_WIFI_TX_BUFFER_TYPE

sdkconfig

@github-actions github-actions bot changed the title Disabling "Support ESP32 internal EMAC controller" breaks build Disabling "Support ESP32 internal EMAC controller" breaks build (IDFGH-1504) Jul 11, 2019
@suda-morris
Copy link
Collaborator

Thank you @nifomorph we will fix it ASAP.

@suda-morris suda-morris self-assigned this Jul 12, 2019
@igrr igrr closed this as completed in 018de81 Jul 25, 2019
trombik pushed a commit to trombik/esp-idf that referenced this issue Aug 9, 2019
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this issue May 5, 2021
This value is uninitialised and as such can be a random (and invalid) value. It's needs to be set per the espressif documentation here:

https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/bluetooth/esp_gap_ble.html#_CPPv4N21esp_ble_scan_params_t14scan_duplicateE

This PR sets it to DUPLICATE_DISABLE. Chosen as this is needed to ensure all scan data is populated in the scan callback, per this comment in the IDF:

https://github.com/espressif/esp-idf/blob/master/components/bt/host/bluedroid/stack/btm/btm_ble_gap.c#L3591

"//if scan duplicate is enabled, the adv packet without scan response is allowed to report to higher layer"

We **don't** want it to report to the higher layer (ie BLEScan.cpp) **unless** it has the active scan response.

Seems to resolve espressif#3770 espressif#3677 and possibly others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants