Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type inconsistency of SSID field #40

Closed
jmattsson opened this issue Oct 4, 2016 · 0 comments

Comments

@jmattsson
Copy link

commented Oct 4, 2016

I'm not sure whether I should even be reporting this, but...

In esp_wifi_types.h the wifi_config_t construct takes an SSID of type char ssid[32]. However, all the WiFi events over in esp_events.h report the SSID of type uint8_t ssid[32]. This in turn quite easily leads to sign-related compiler warnings. It would be nice if all ssid instances were plain char ssid[32], or at least all agreed on the signedness of octets making up an SSID (I could definitely see an argument for making it uint8_t rather than char).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.