Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type inconsistency of SSID field #40

Closed
jmattsson opened this issue Oct 4, 2016 · 0 comments
Closed

Type inconsistency of SSID field #40

jmattsson opened this issue Oct 4, 2016 · 0 comments
Assignees
@igrr
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally

Comments

@jmattsson
Copy link

I'm not sure whether I should even be reporting this, but...

In esp_wifi_types.h the wifi_config_t construct takes an SSID of type char ssid[32]. However, all the WiFi events over in esp_events.h report the SSID of type uint8_t ssid[32]. This in turn quite easily leads to sign-related compiler warnings. It would be nice if all ssid instances were plain char ssid[32], or at least all agreed on the signedness of octets making up an SSID (I could definitely see an argument for making it uint8_t rather than char).
@igrr igrr self-assigned this Oct 14, 2016
@projectgus projectgus added the Status: In Progress Work is in progress label Dec 22, 2016
igrr pushed a commit that referenced this issue Dec 29, 2016
@projectgus
WiFi interface: SSID and password fields should be uint8_t in all cases
c1a6d55 
Closes github #40 #40
@igrr igrr removed the Status: In Progress Work is in progress label Jan 16, 2017
@joehui joehui mentioned this issue Jun 4, 2020
Open
@rokmarko rokmarko mentioned this issue Nov 9, 2021
Closed
@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 10, 2022
@espressif-bot espressif-bot added Resolution: Won't Do This will not be worked on Status: Done Issue is done internally and removed Status: Opened Issue is new labels Feb 23, 2022
mikkeldamsgaard pushed a commit to mikkeldamsgaard/esp-idf that referenced this issue Mar 26, 2022
Report allocation errors from UART (espressif#40)
35fd4dd
mikkeldamsgaard pushed a commit to mikkeldamsgaard/esp-idf that referenced this issue Sep 28, 2022
@floitsch
Report allocation errors from UART (espressif#40)
264b957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igrr igrr

Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@projectgus @jmattsson @igrr @espressif-bot