-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small memory leak in esp_mqtt_client_init error path (IDFGH-2235) #4384
Comments
github-actions
bot
changed the title
small memory leak in esp_mqtt_client_init error path
small memory leak in esp_mqtt_client_init error path (IDFGH-2235)
Nov 21, 2019
Thanks for reporting this issue, we'll make sure to fix this in our next MQTT update. |
david-cermak
pushed a commit
to espressif/esp-mqtt
that referenced
this issue
Nov 22, 2019
Closes espressif/esp-idf#4384 Closes IDFGH-2235
espressif-bot
pushed a commit
that referenced
this issue
Jan 23, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: esp-mqtt/merge_requests/53 Closes FCS-267
espressif-bot
pushed a commit
that referenced
this issue
Jan 24, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: esp-mqtt/merge_requests/53 Closes FCS-267
espressif-bot
pushed a commit
that referenced
this issue
Feb 21, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: esp-mqtt/merge_requests/53 Closes FCS-267
david-cermak
pushed a commit
to espressif/esp-mqtt
that referenced
this issue
Dec 16, 2022
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes #137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes espressif/esp-idf#4349 Closes #140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes espressif/esp-idf#4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes espressif/esp-idf#4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
egnor
pushed a commit
to egnor/esp-mqtt
that referenced
this issue
Dec 23, 2022
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif#137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes espressif/esp-idf#4349 Closes espressif#140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes espressif/esp-idf#4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes espressif/esp-idf#4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
egnor
pushed a commit
to egnor/esp-mqtt
that referenced
this issue
Dec 23, 2022
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif#137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes espressif/esp-idf#4349 Closes espressif#140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes espressif/esp-idf#4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes espressif/esp-idf#4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In IDF-4.0-beta2.
Need to free client->event.error_handle if create mutex for client->api_lock fails.
`
diff --git a/mqtt_client.c b/mqtt_client.c
index 19458f7dc7aa..2343a5c1c78c 100644
--- a/mqtt_client.c
+++ b/mqtt_client.c
@@ -374,6 +374,7 @@ esp_mqtt_client_handle_t esp_mqtt_client_init(const esp_mqtt_client_config_t *co
}
client->api_lock = xSemaphoreCreateMutex();
if (!client->api_lock) {
`
The text was updated successfully, but these errors were encountered: