'esp_mqtt_client_publish()' fail return -1? #140
Comments
|
Hi, davctv. Thanks for reporting this issue. Yes, the error handling in the current version is not correct, as you point out it doesn't return -1 if it fails. If it fails sending you will get an There is a merge request ready that should improve this. |
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this issue
Jan 10, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this issue
Jan 23, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: esp-mqtt/merge_requests/53 Closes FCS-267
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this issue
Jan 24, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: esp-mqtt/merge_requests/53 Closes FCS-267
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this issue
Feb 21, 2020
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif/esp-mqtt#137 MQTT MR: esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes #4349 Closes espressif/esp-mqtt#140 MQTT MR: esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes #4384 MQTT MR: esp-mqtt/merge_requests/49 Closes #4433 Closes IDFGH-2293 MQTT MR: esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: esp-mqtt/merge_requests/53 Closes FCS-267
david-cermak
pushed a commit
that referenced
this issue
Dec 16, 2022
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes #137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes espressif/esp-idf#4349 Closes #140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes espressif/esp-idf#4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes espressif/esp-idf#4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
egnor
pushed a commit
to egnor/esp-mqtt
that referenced
this issue
Dec 23, 2022
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif#137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes espressif/esp-idf#4349 Closes espressif#140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes espressif/esp-idf#4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes espressif/esp-idf#4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
egnor
pushed a commit
to egnor/esp-mqtt
that referenced
this issue
Dec 23, 2022
Adds bugfixes for: - Too early publishing - Potential mutex memory leak - CI related issues. - Wait for entire connack message - Event loop not getting cleaned up Adds support for ALPN, configurable reconnect time, QEMU CI tests and password protected client key. MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/46 Closes IDF-1162 Closes espressif#137 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/47 Closes IDF-1126 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2197 Closes espressif/esp-idf#4349 Closes espressif#140 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/48 Closes IDFGH-2235 Closes espressif/esp-idf#4384 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/49 Closes espressif/esp-idf#4433 Closes IDFGH-2293 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/50 Closes FCS-254 MQTT MR: https://gitlab.espressif.cn:6688/espressif/esp-mqtt/merge_requests/53 Closes FCS-267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @david-cermak,
I'm using 'esp_mqtt_client_publish()' function but looking into source code I think that the return value -1 (fail) never occurs. It only returns 0 or pending_msg_id (which is never assigned to -1. Am I wrong?
Thus, how can I know if publish is completed correctly? I currently I check 'MQTT_EVENT_PUBLISHED' but what if 'esp_mqtt_client_publish()' fails and the message is not queued in the mqtt task?
Thanks in advance
The text was updated successfully, but these errors were encountered: