Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Allow runtime config mqtt protocol version (IDFGH-2311) #4448

Closed
AxelLin opened this issue Dec 6, 2019 · 3 comments
Closed

Feature request: Allow runtime config mqtt protocol version (IDFGH-2311) #4448

AxelLin opened this issue Dec 6, 2019 · 3 comments

Comments

@AxelLin
Copy link
Contributor

AxelLin commented Dec 6, 2019

The ESP-MQTT supports MQTT protocol 3.1 and MQTT protocol 3.1.1.
But it is decided at compile time by selecting MQTT_PROTOCOL_311 or not.
This is a mqtt clinet implemenation it should allow config using 3.1 or 3.1.1
at runtime because it's not possible to decide if the target mqtt broker support 3.1.1 or not.

Suggest providing API to allow config mqtt protocol version at runtime.
@github-actions github-actions bot changed the title Feature request: Allow runtime config mqtt protocol version Feature request: Allow runtime config mqtt protocol version (IDFGH-2311) Dec 6, 2019
@AxelLin
Copy link
Contributor Author

AxelLin commented Dec 11, 2019

The esp-mqtt is in another git tree (https://github.com/espressif/esp-mqtt).
So I'm wondering if I should move this issue from esp-idf to esp-mqtt or
just keep it here? comments?

@david-cermak
Copy link
Collaborator

@AxelLin You can leave the issue here and it will be processed as IDF issue, so closed once the IDF references the esp-mqtt submodule supporting this feature.

I think it is a good idea to support runtime selection of mqtt protocol. Thank you for this suggestion!

david-cermak pushed a commit to espressif/esp-mqtt that referenced this issue Jan 20, 2020
@ESP-Marius
MQTT: Add runtime selection of mqtt protocol version
7ac0a42 
Add config option for selecting protocol version at runtime.

This also fixed MQTT protocol version 3.1 which wasnt working with the original implementation

Closes espressif/esp-idf#4448
Closes IDFGH-2311
Closes IDF-1320
@AxelLin
Copy link
Contributor Author

AxelLin commented Feb 11, 2020

Thank you for adding this feature.

@AxelLin AxelLin closed this as completed Feb 11, 2020
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this issue May 5, 2021
@MHotchin
Fixes espressif#4435 - WiFiClient improperly treats zero data availab…
7e40de2 
…le for read as an error (espressif#4448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AxelLin @david-cermak