Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unlimited HCI Extended Features Pages by default (IDFGH-3515) #5470

Closed
DerfJagged opened this issue Jun 19, 2020 · 2 comments
Closed

Allow unlimited HCI Extended Features Pages by default (IDFGH-3515) #5470

DerfJagged opened this issue Jun 19, 2020 · 2 comments
Labels
Type: Feature Request Feature request for IDF

Comments

@DerfJagged
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Yes. When you connect an Xbox One S controller to the ESP32 by running the esp_hid_host example, it errors out in btm_read_remote_ext_features_complete due to HCI_EXT_FEATURES_PAGE_MAX being set to 2 when the Xbox One controller has 3 pages. If you comment out the return line, it works great.

Describe the solution you'd like

To not return when pages > 3. HCI_EXT_FEATURES_PAGE_1 and HCI_EXT_FEATURES_PAGE_2 are unhandled in code anyway (empty functions), so I don't see the harm in allowing any number of pages to maximize compatibility.

Describe alternatives you've considered

Give a warning instead of returning.

Thank you!
@DerfJagged DerfJagged added the Type: Feature Request Feature request for IDF label Jun 19, 2020
@github-actions github-actions bot changed the title Allow unlimited HCI Extended Features Pages by default Allow unlimited HCI Extended Features Pages by default (IDFGH-3515) Jun 19, 2020
@ghost
Copy link

ghost commented Jun 22, 2020

Hi @DerfJagged

We agree with you about the fix, so would you like to commit a PR?

Thanks
Weitianhua

@DerfJagged
Copy link
Contributor Author

@Wth-Esp done! Thank you.

#5481

projectgus pushed a commit that referenced this issue Jul 22, 2020
@DerfJagged @boblane1
Support for more Bluetooth HID devices
d1506fd 
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages.
(IDFGH-3515)

Signed-off-by: liqigan <liqigan@espressif.com>

Merges #5481
Closes #5470
espressif-bot pushed a commit that referenced this issue Aug 1, 2020
@DerfJagged @boblane1
Support for more Bluetooth HID devices
a1cf4fa 
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages.
(IDFGH-3515)

Signed-off-by: liqigan <liqigan@espressif.com>

Merges #5481
Closes #5470
espressif-bot pushed a commit that referenced this issue Aug 3, 2020
@DerfJagged @boblane1
Support for more Bluetooth HID devices
5705c78 
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages.
(IDFGH-3515)

Signed-off-by: liqigan <liqigan@espressif.com>

Merges #5481
Closes #5470
espressif-bot pushed a commit that referenced this issue Sep 10, 2020
@DerfJagged @boblane1
Support for more Bluetooth HID devices
16e33e3 
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages.
(IDFGH-3515)

Signed-off-by: liqigan <liqigan@espressif.com>

Merges #5481
Closes #5470
espressif-bot pushed a commit that referenced this issue Oct 30, 2020
@boblane1 @espressif-bot
Some Bluetooth devices - such as an Xbox One S controller (model 1708…
c5b23a8 
…) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages.

(IDFGH-3515)
Signed-off-by: liqigan <liqigan@espressif.com>

Merges #5481
Closes #5470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Request Feature request for IDF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DerfJagged