-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unlimited HCI Extended Features Pages by default (IDFGH-3515) #5470
Labels
Type: Feature Request
Feature request for IDF
Comments
github-actions
bot
changed the title
Allow unlimited HCI Extended Features Pages by default
Allow unlimited HCI Extended Features Pages by default (IDFGH-3515)
Jun 19, 2020
Hi @DerfJagged We agree with you about the fix, so would you like to commit a PR? Thanks |
@Wth-Esp done! Thank you. |
projectgus
pushed a commit
that referenced
this issue
Jul 22, 2020
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages. (IDFGH-3515) Signed-off-by: liqigan <liqigan@espressif.com> Merges #5481 Closes #5470
espressif-bot
pushed a commit
that referenced
this issue
Aug 1, 2020
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages. (IDFGH-3515) Signed-off-by: liqigan <liqigan@espressif.com> Merges #5481 Closes #5470
espressif-bot
pushed a commit
that referenced
this issue
Aug 3, 2020
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages. (IDFGH-3515) Signed-off-by: liqigan <liqigan@espressif.com> Merges #5481 Closes #5470
espressif-bot
pushed a commit
that referenced
this issue
Sep 10, 2020
Some Bluetooth devices - such as an Xbox One S controller (model 1708) - report more than two external features pages and are rejected immediately. Pages 1 and 2 are marked as unhandled in btm_devctl.c anyway, so there is no reason to block devices with more pages. (IDFGH-3515) Signed-off-by: liqigan <liqigan@espressif.com> Merges #5481 Closes #5470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Yes. When you connect an Xbox One S controller to the ESP32 by running the esp_hid_host example, it errors out in
btm_read_remote_ext_features_complete
due to HCI_EXT_FEATURES_PAGE_MAX being set to 2 when the Xbox One controller has 3 pages. If you comment out thereturn
line, it works great.Describe the solution you'd like
To not
return
when pages > 3. HCI_EXT_FEATURES_PAGE_1 and HCI_EXT_FEATURES_PAGE_2 are unhandled in code anyway (empty functions), so I don't see the harm in allowing any number of pages to maximize compatibility.Describe alternatives you've considered
Give a warning instead of returning.
Thank you!
The text was updated successfully, but these errors were encountered: