Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uart sample has extra parameter in uart_driver_install #91

Closed
nkolban opened this issue Nov 11, 2016 · 0 comments
Closed

Uart sample has extra parameter in uart_driver_install #91

nkolban opened this issue Nov 11, 2016 · 0 comments

Comments

@nkolban
Copy link
Contributor

nkolban commented Nov 11, 2016

If we look at this source line in the code ...

https://github.com/espressif/esp-idf/blob/master/components/driver/include/driver/uart.h#L751

We see that there is currently an extra parameter at the end of the call to uart_driver_install. This parameter is supplied as RINGBUF_TYPE_BYTEBUF. Unfortunately, this parameter doesn't map to the signature of the function. I believe that the parameter needs to be removed from the sample.

@projectgus projectgus added the Status: In Progress Work is in progress label Dec 22, 2016
igrr pushed a commit that referenced this issue Dec 29, 2016
@igrr igrr removed the Status: In Progress Work is in progress label Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants