Make PPPoS run (again) after latest lwip changes #1028
Conversation
|
|
|
Hi @loboris, I haven't had time to look at this properly yet (sorry), but this seems to revert some changes that were required to allow APSTA modes to coexist & route properly (ie allow the ESP32 to route to the internet via a STA interface while sending/receiving packets on the AP interface). Is it possible there is some other way to configure routes & addresses in LWIP to make the PPPoS interface work correctly? |
|
I'll try some other solutions. Usualy, we use PPPoS when we have no WiFi Internet connection and STA mode is not used (and canno't be used), so APSTA mode is also not used. In that case, we connect to the Internet via GSM/PPPoS and (eventualy) use AP mode to connect to the ESP32 (and possibe route the traffic to the Internet). |
|
@loboris I think this should be made to work also when APSTA is used. I'll have a look as well. |
|
In PPPoS gw address is set to 10.64.64.64, we can check it in ip4_route function (ip4.c) and return the netif if other checks fail. |
|
Hmm, that's an interesting fix but I don't think hardcoding interface-specific addresses in the IP stack routing layer is a good idea. It should be possible to externally configure LWIP's routes so that it knows what your preferences for routing are. |
|
I'm avare that it is a dirty fix, for now it's working for me until I (or someone else) find the better solution. @danicampora |
Pointer tcpip_api_call *m should be converted to pppapi_msg* instead of pppapi_msg_msg* in pppapi_do_ppp_set_default(), pppapi_do_ppp_free() and so on. It solve this issue espressif#1028 so there is no need to patch ip4.c because now netif_defauilt is setted correctly. Also it prevents memory corruption when pppapi_free() is called.
|
Better solution found: |
Pointer tcpip_api_call *m should be converted to pppapi_msg* instead of pppapi_msg_msg* in pppapi_do_ppp_set_default(), pppapi_do_ppp_free() and so on. It solve this issue #1028 so there is no need to patch ip4.c because now netif_defauilt is setted correctly. Also it prevents memory corruption when pppapi_free() is called.
There was a problen running PPPoS after latest changes to lwip (#1017).
This simple patch makes it run again.