Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that SPI Flash pins are not for regular usage. (IDFGH-8942) #10356

Merged
merged 1 commit into from Dec 14, 2022
Merged

Enforce that SPI Flash pins are not for regular usage. (IDFGH-8942) #10356

merged 1 commit into from Dec 14, 2022

Conversation

SuGlider
Copy link
Contributor

@SuGlider SuGlider commented Dec 12, 2022 •
edited

This PR intends to help users to understand that the JP2 SPI Flash exposed pins are not for free usage. This was mentioned in the Arduino Project at espressif/arduino-esp32#7465

Closes espressif/arduino-esp32#7465

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 12, 2022
@github-actions github-actions bot changed the title Enforce that SPI Flash pins are not for regular usage. Enforce that SPI Flash pins are not for regular usage. (IDFGH-8942) Dec 12, 2022
@SuGlider SuGlider mentioned this pull request Dec 12, 2022
Closed
1 task
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@krzychb
Copy link
Collaborator

krzychb commented Dec 13, 2022

Hi @SuGlider, LGTM. Thank you!

@krzychb krzychb added the PR-Sync-Merge Pull request sync as merge commit label Dec 13, 2022
@espressif espressif deleted a comment from krzychb Dec 13, 2022
@suda-morris
Copy link
Collaborator

sha=1a8816ca974ddfc0f0a726a553b71f6511f32aeb

@suda-morris suda-morris added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Dec 13, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Dec 13, 2022
@espressif-bot espressif-bot merged commit c01f71c into espressif:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krzychb krzychb

Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrover-kit SPI not working SD0-3 CLK
6 participants
@SuGlider @CLAassistant @Alvin1Zhang @krzychb @suda-morris @espressif-bot