Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop on esp_http_client_fetch_headers #2534

Closed
wants to merge 1 commit into from
Closed

Fix infinite loop on esp_http_client_fetch_headers #2534

wants to merge 1 commit into from

Conversation

R-Damian
Copy link
Contributor

@R-Damian R-Damian commented Oct 9, 2018

error must also be returned if esp_tls_conn_read return 0 because socket was closed

error must also be returned if esp_tls_conn_read return 0 because socket  was closed
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2018

CLA assistant check
All committers have signed the CLA.

@igrr igrr requested a review from tuanpmt October 23, 2018 06:58
Copy link
Contributor

@tuanpmt tuanpmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thank you for the fixed

igrr pushed a commit that referenced this pull request Nov 18, 2018
error must also be returned if esp_tls_conn_read return 0 because socket  was closed

Merges #2534
@mahavirj
Copy link
Member

Thanks for your contribution, change is now merged.

@mahavirj mahavirj closed this Nov 18, 2018
@R-Damian R-Damian deleted the patch-1 branch November 27, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants