Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where esp_vfs_unregister would unregister root file system #2770

Closed
wants to merge 1 commit into from
Closed

Conversation

ThomasRogg
Copy link

when it should unregister sub-filesystem (such as /sdcard)
path comparison must be exact here

when it should unregister sub-filesystem (such as /sdcard)
path comparison must be exact here
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ThomasRogg
Copy link
Author

Won't sign license agreement, not worth the hassle for me.
This is a clear bug. I would suggest you fix this.

@igrr
Copy link
Member

igrr commented Dec 4, 2018

Thanks for finding the bug and submitting the PR, @neoniousTR! Since you have not signed the CLA, we'll treat this as an issue report. Will keep this open until respective fix is merged.

@ThomasRogg
Copy link
Author

You're welcome.

@igrr igrr closed this in 61beb16 Dec 7, 2018
@fivdi
Copy link
Contributor

fivdi commented Dec 27, 2018

Won't sign license agreement, not worth the hassle for me.

@neoniousTR I'm not sure if you are aware of this but signing the license agreement should actually be easy and if I'm not mistaken it can be done with your GitHub account. Just click on the "CLA | not signed yet" badge in the above post and follow the instructions.

igrr added a commit that referenced this pull request Jan 24, 2019
igrr added a commit that referenced this pull request Jan 24, 2019
catalinio pushed a commit to catalinio/pycom-esp-idf that referenced this pull request Jun 28, 2019
catalinio pushed a commit to catalinio/pycom-esp-idf that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants