if esp-idf is a submodule, then everything except this check works #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forking this repo, and then customizing on top of it, (and then later having to reconcile changes), I have a root repo with all my goodies and then an esp-idf submodule.
It just works! Except that esp-idf's make process does a check for
${IDF_PATH}/.git
-- which doesn't exist when esp-idf is a submodule. I don't really see the point of this check, since if esp-idf cannot be manipulated by git, any number of git commands in the makefile will fail and the build will stop.