Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp_https_server: fix HTTPD_SSL_CONFIG_DEFAULT (IDFGH-2948) #4981

Closed
wants to merge 1 commit into from
Closed

esp_https_server: fix HTTPD_SSL_CONFIG_DEFAULT (IDFGH-2948) #4981

wants to merge 1 commit into from

Conversation

jeandudey
Copy link

This macro didn't compile on C++. Order is fixed now.

@jeandudey @xkevin190
esp_https_server: fix HTTPD_SSL_CONFIG_DEFAULT
cbba56b 
This macro doesn't compile on C++. Order is fixed now.

Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
Co-Authored-By: xkevin190 <kevinvelasco193@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Mar 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title esp_https_server: fix HTTPD_SSL_CONFIG_DEFAULT esp_https_server: fix HTTPD_SSL_CONFIG_DEFAULT (IDFGH-2948) Mar 24, 2020
@jeandudey jeandudey mentioned this pull request Mar 24, 2020
Closed
@Alvin1Zhang
Copy link
Collaborator

@jeandudey Thanks for contribution.

AdityaHPatwardhan
AdityaHPatwardhan approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@AdityaHPatwardhan AdityaHPatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the order, It got messed up in a recent commit about mututal authentication.

@jeandudey
Copy link
Author

Thank you all for reviewing! 👍

@mahavirj mahavirj mentioned this pull request Mar 31, 2020
Closed
espressif-bot pushed a commit that referenced this pull request Mar 31, 2020
@AdityaHPatwardhan @mahavirj
esp_https_server: fix HTTPD_SSL_CONFIG_DEFAULT
22b1607 
This macro doesn't compile on C++. Order is fixed now.

Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
Co-Authored-By: xkevin190 <kevinvelasco193@gmail.com>

Merges #4981
@mahavirj
Copy link
Member

mahavirj commented Apr 1, 2020

Fixed with 22b1607

@mahavirj mahavirj closed this Apr 1, 2020
@jeandudey jeandudey deleted the 2020_03_23-https branch April 1, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaHPatwardhan AdityaHPatwardhan AdityaHPatwardhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeandudey @CLAassistant @Alvin1Zhang @mahavirj @AdityaHPatwardhan