Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick missing commit 7a2885885c25821d8985b6a97798956f12907b5a to master (IDFGH-3157) #5171

Closed
wants to merge 1 commit into from

Conversation

Hallot
Copy link

@Hallot Hallot commented Apr 23, 2020

See: https://www.esp32.com/viewtopic.php?f=13&t=14978

spi_flash: Add vTaskDelay while a long erasing
Added Kconfig options to enable yield operation during flash erase

Closes: #2083
Closes: IDFGH-261

Added Kconfig options to enable yield operation during flash erase

Closes: espressif#2083
Closes: IDFGH-261
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title Cherry-pick missing commit 7a2885885c25821d8985b6a97798956f12907b5a to master Cherry-pick missing commit 7a2885885c25821d8985b6a97798956f12907b5a to master (IDFGH-3157) Apr 23, 2020
@Hallot
Copy link
Author

Hallot commented Apr 27, 2020

Signing CLA does not seem to work, I've done it multiple times already, to no avail.

@mahavirj
Copy link
Member

@Hallot We have fix for this already submitted in our internal merge requests queue. It will soon reflect to github as well. You can probable close this PR.

@Hallot Hallot closed this Apr 27, 2020
@projectgus
Copy link
Contributor

@Hallot ,

Thanks again for this, the internal fix for this should be pushed to GitHub very soon. (We cherry-picked this commit but also implemented this feature for the new SPI Flash API added in V4.0).

For the record:

Signing CLA does not seem to work, I've done it multiple times already, to no avail.

It doesn't matter in this case, but for future reference this didn't work because the email address used for the commit isn't associated with your GitHub account (if you look at the commit shown above you can see that there's anonymous GitHub user shown as the committer). So the CLA bot has no way to know who the committer for this change is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp_ota_begin() starving network task of cpu time with large partitions and SPI RAM (IDFGH-261)
5 participants