Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp_crt_bundle: remove EC-ACC certificate (IDFGH-5944) #7632

Merged
merged 1 commit into from
Oct 12, 2021
Merged

esp_crt_bundle: remove EC-ACC certificate (IDFGH-5944) #7632

merged 1 commit into from
Oct 12, 2021

Conversation

electrocucaracha
Copy link
Contributor

Removing the EC-ACC certificate given it has Negative serial value invalid for RFC 5280.

Fix #7631

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 1, 2021
@github-actions github-actions bot changed the title esp_crt_bundle: remove EC-ACC certificate esp_crt_bundle: remove EC-ACC certificate (IDFGH-5944) Oct 1, 2021
@electrocucaracha electrocucaracha mentioned this pull request Oct 2, 2021
Merged
RadicalDev
RadicalDev reviewed Oct 2, 2021
View reviewed changes
Copy link

@RadicalDev RadicalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@electrocucaracha electrocucaracha mentioned this pull request Oct 2, 2021
Closed
@asurti9
Copy link

asurti9 commented Oct 5, 2021

Thanks for the quick fix!
Is this fix permanent? Or we will be having a permanent fix in future?

@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Opened Issue is new labels Oct 5, 2021
@igrr
Copy link
Member

igrr commented Oct 5, 2021

@asurti9 There will be a follow-up update of the certificate bundle, please see #7631 (comment).

dereulenspiegel added a commit to krach-protocol/smol-noice that referenced this pull request Oct 5, 2021
@dereulenspiegel
Disabled certificate bundle in project sdkconfig as this is causing e…
d0c127e 
…rror currently. See espressif/esp-idf#7632
@mahavirj mahavirj mentioned this pull request Oct 8, 2021
Closed
@igrr igrr merged commit f2d0526 into espressif:master Oct 12, 2021
@electrocucaracha electrocucaracha deleted the fix_remove_invalid_cert branch October 12, 2021 14:22
@SreeneshTKC
Copy link

SreeneshTKC commented Oct 14, 2021 •
edited
Loading

Thanks for pointing it out. It works!

@mat-duf
Copy link

mat-duf commented Oct 15, 2021

This is the only solution I found that works so far, thank you so much!

KlausPopp added a commit to ci4rail/esp-idf that referenced this pull request Oct 28, 2021
@KlausPopp
fix mbedtls/esp_crt_bundle/cacrt_all.pem, see espressif#7632
89ada96
@niwantha33
Copy link

it works. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadicalDev RadicalDev RadicalDev left review comments

@mahavirj mahavirj mahavirj approved these changes

Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't load some certificates with cryptography v35.0.0 (IDFGH-5943)
9 participants
@electrocucaracha @asurti9 @igrr @SreeneshTKC @mat-duf @niwantha33 @mahavirj @RadicalDev @espressif-bot