-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Docker best practices on ESP32 image #10165
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
electrocucaracha:fix_esp32_img
Oct 7, 2021
Merged
Implement Docker best practices on ESP32 image #10165
bzbarsky-apple
merged 1 commit into
project-chip:master
from
electrocucaracha:fix_esp32_img
Oct 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Morales <v.morales@samsung.com>
Remove this patch once espressif/esp-idf#7632 is available
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
turon
October 2, 2021 01:37
andy31415
reviewed
Oct 5, 2021
andy31415
approved these changes
Oct 5, 2021
jmartinez-silabs
approved these changes
Oct 5, 2021
woody-apple
approved these changes
Oct 7, 2021
Ugh. I just realized that this had an undetected merge conflict: our docker version is already at 0.5.11. @andreilitvin @woody-apple Do we want to just do a standalone version bump, or revert this and reland with a version bump? |
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 7, 2021
This should have happened in project-chip#10165 but didn't due to an undetected merge conflict.
andy31415
pushed a commit
that referenced
this pull request
Oct 7, 2021
This should have happened in #10165 but didn't due to an undetected merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous attempt to reduce the image size and implement Docker best practices occurred when cryptography module was released. This python module doesn't allow to loading of X.509 certificates with negative serial numbers. A fix has been submitted to Espressif IoT Development Framework but we need to keep a patch until it's available.
Change overview
This change implements Docker best practices validated with Hadolint tool which helps to reduce the size. It also contains a patch file which removes the invalid certificate.
Fixes #10123
Testing
It was created ESP32 and ESP32 QEMU images locally and use act to validate the execution.