Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Docker best practices on ESP32 image #10165

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

electrocucaracha
Copy link
Collaborator

@electrocucaracha electrocucaracha commented Oct 2, 2021

Problem

Previous attempt to reduce the image size and implement Docker best practices occurred when cryptography module was released. This python module doesn't allow to loading of X.509 certificates with negative serial numbers. A fix has been submitted to Espressif IoT Development Framework but we need to keep a patch until it's available.

Change overview

This change implements Docker best practices validated with Hadolint tool which helps to reduce the size. It also contains a patch file which removes the invalid certificate.

Fixes #10123

Testing

It was created ESP32 and ESP32 QEMU images locally and use act to validate the execution.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@todo
Copy link

todo bot commented Oct 2, 2021

Remove this patch once espressif/esp-idf#7632 is available

# TODO: Remove this patch once https://github.com/espressif/esp-idf/pull/7632 is available
COPY 0001-esp_crt_bundle-remove-EC-ACC-certificate.patch /tmp/esp-idf/0001-esp_crt_bundle-remove-EC-ACC-certificate.patch
WORKDIR /tmp/esp-idf
RUN set -x \
&& git apply /tmp/esp-idf/0001-esp_crt_bundle-remove-EC-ACC-certificate.patch \
&& rm -f /tmp/esp-idf/0001-esp_crt_bundle-remove-EC-ACC-certificate.patch \
&& : # last line
FROM connectedhomeip/chip-build:${VERSION}


This comment was generated by todo based on a TODO comment in e17daa5 in #10165. cc @electrocucaracha.

@bzbarsky-apple
Copy link
Contributor

Ugh. I just realized that this had an undetected merge conflict: our docker version is already at 0.5.11. @andreilitvin @woody-apple Do we want to just do a standalone version bump, or revert this and reland with a version bump?

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 7, 2021
This should have happened in
project-chip#10165 but didn't
due to an undetected merge conflict.
andy31415 pushed a commit that referenced this pull request Oct 7, 2021
This should have happened in
#10165 but didn't
due to an undetected merge conflict.
@electrocucaracha electrocucaracha deleted the fix_esp32_img branch October 7, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out why QEMU fails post 0.5.7 docker tag
5 participants