Add uart api call to use xon/xoff flow control #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @Ealdwulf , Thanks for sending this. Are you able to click-through and sign our CLA as prompted, please? Once CLA is signed we can look at merging the PR. Angus |
|
Thanks @projectgus, my manager confirmed this was okay, so I have signed it. |
|
Thanks @Ealdwulf . Have cherry-picked this into our internal queue for review & merging. |
igrr
added a commit
that referenced
this pull request
Sep 18, 2017
uart: Add api call to switch on hardware support for 'software' flow control. (github #890) See merge request !1215
|
Cherry-picked as 23f10e1. |
|
Cheers! |
chmorgan
pushed a commit
to chmorgan/esp-idf
that referenced
this pull request
Sep 20, 2017
…control. Cherry-picks espressif#890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uart driver has support for hardware flow control, but we (Kano Computing) are using a flow control pin to control device reset, which I guess is a common use case. We'd therefore like to use software flow control. Since the hardware has this build in, I've made this PR to switch it on.
We are not especially attached to this API and would be fine with anything which does the same job.