Fix for getProjectName (VSC-262) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Merge master from espressif/vscode-esp-idf-extension
brianignacio5
added a commit
that referenced
this pull request
Mar 24, 2020
fix uppercase search (#47) read Cmakelists file for project name (VSC-248) (#43) read build project_description json file for project name Feature/localization kv val (VSC-226) (VSC-246) (#41) * add gulp i18n validation and src missing key log rm unused i18n field, add unknown field (#48) v0.1.4 add gif in readme (VSC-256) (#51) * add gif in readme * slower frame rate gif update idf tools on idf download, refactor some promise await (#54) Fix for getProjectName (VSC-262) (#57) * 🐛 Fix continued execution * Yarn Audit dependency upgrade Added a custom Debug Adapter fix old configs remove build before debug fix debug adapter unit test DA python pkgs check (#3) * read Cmakelists file for project name (VSC-248) (#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (#48) * v0.1.4 * Added a custom Debug Adapter * fix old configs remove build before debug * removed outdated extension.test.ts * fix debug adapter unit test * removed repeated options * removed redundant requirements.txt * made `Upload testing.results.log` always executable * add adapter python reqs checking Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> Co-authored-by: Andrey Gramakov <mail@agramakov.me> Fix/da merge (#4) * read Cmakelists file for project name (VSC-248) (#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (#48) * v0.1.4 * Added a custom Debug Adapter * fix old configs remove build before debug * fix debug adapter unit test * DA python pkgs check (#3) * read Cmakelists file for project name (VSC-248) (#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (#48) * v0.1.4 * Added a custom Debug Adapter * fix old configs remove build before debug * removed outdated extension.test.ts * fix debug adapter unit test * removed repeated options * removed redundant requirements.txt * made `Upload testing.results.log` always executable * add adapter python reqs checking Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> Co-authored-by: Andrey Gramakov <mail@agramakov.me> * fix merge issues * log adapter output Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> Co-authored-by: Andrey Gramakov <mail@agramakov.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getProjectName()was continuing execution even if promise was rejectedReturn
rejectorresolveso that out of branch execution is stopped