Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio Code hangs when closing integrated-terminal running menuconfig (IDFGH-2443) (VSC-168) #4

Closed
Devenda opened this issue Dec 29, 2019 · 2 comments
Closed

Visual Studio Code hangs when closing integrated-terminal running menuconfig (IDFGH-2443) (VSC-168) #4

Devenda opened this issue Dec 29, 2019 · 2 comments
Labels
stale Stale PR or Issue vscode related problem This issue is related to the bug/ behaviours of the vscode and not the extension itself

Comments

@Devenda
Copy link

Devenda commented Dec 29, 2019

Environment

  • IDF version (run git describe --tags to find it):
    v4.1-dev-1572-g30372f5a4
  • Build System: [CMake]
  • Compiler version (run xtensa-esp32-elf-gcc --version to find it):
    xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0
  • Operating System: [Windows]

Problem Description

When closing the vs code integrated-terminal when it's showing the menuconfig vscode hangs.

This seems to be a vscode issue, but I'm not to sure about that as I'm unable to find the root cause.

I think it may be due to idf.py starting a sub binary (the kconfig-frontend?), but not handling the closing of the terminal correctly?

I also tested this when running an infinite loop in a python script and also calling a different executable (cmd.exe) from a python script, but both times closing the terminal worked as expected.

All ideas are welcome!

See microsoft/vscode#87840 for more details.
@github-actions github-actions bot changed the title Visual Studio Code hangs when closing integrated-terminal running menuconfig Visual Studio Code hangs when closing integrated-terminal running menuconfig (IDFGH-2443) Dec 29, 2019
@projectgus projectgus transferred this issue from espressif/esp-idf Jan 7, 2020
@projectgus
Copy link

(Moving this into VSCode Extension because even though the extension isn't responsible for this, it seems like any fix will probably need to come via the extension.)

@github-actions github-actions bot changed the title Visual Studio Code hangs when closing integrated-terminal running menuconfig (IDFGH-2443) Visual Studio Code hangs when closing integrated-terminal running menuconfig (IDFGH-2443) (VSC-168) Jan 7, 2020
@pwmb
Copy link
Contributor

pwmb commented Jan 7, 2020

@Devenda Since we don't have control over the terminal inside the vscode directly, for this reason in the ESP IDF Official VSCode Extension we have provided support for the Menuconfig, use that insted.

Visit the extension marketplace to know more.

@pwmb pwmb added the vscode related problem This issue is related to the bug/ behaviours of the vscode and not the extension itself label Jan 7, 2020
@pwmb pwmb added the stale Stale PR or Issue label Jan 21, 2020
@pwmb pwmb closed this as completed Jan 21, 2020
brianignacio5 added a commit to brianignacio5/vscode-esp-idf-extension that referenced this issue Mar 10, 2020
@brianignacio5 @pwmb @an-dr
Fix/da merge (espressif#4)
bc40aef 
* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* fix debug adapter unit test

* DA python pkgs check (espressif#3)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* fix merge issues

* log adapter output

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>
brianignacio5 added a commit that referenced this issue Mar 24, 2020
@brianignacio5 @pwmb @an-dr
fix python env bin update after re onboarding (#42)
d6805d9 
fix uppercase search (#47)

read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

rm unused i18n field, add unknown field (#48)

v0.1.4

add gif in readme (VSC-256) (#51)

* add gif in readme

* slower frame rate gif

update idf tools on idf download, refactor some promise await (#54)

Fix for getProjectName (VSC-262) (#57)

* 🐛 Fix continued execution
* Yarn Audit dependency upgrade

Added a custom Debug Adapter

fix old configs remove build before debug

fix debug adapter unit test

DA python pkgs check (#3)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

Fix/da merge (#4)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* fix debug adapter unit test

* DA python pkgs check (#3)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* fix merge issues

* log adapter output

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>
brianignacio5 pushed a commit to brianignacio5/vscode-esp-idf-extension that referenced this issue Mar 25, 2020
@an-dr @brianignacio5
Added a custom Debug Adapter
925d9c7 
fix old configs remove build before debug

fix debug adapter unit test

DA python pkgs check (espressif#3)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

Fix/da merge (espressif#4)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* fix debug adapter unit test

* DA python pkgs check (espressif#3)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* fix merge issues

* log adapter output

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

An dr/feature/debug adapter (espressif#5)

Fix Espressif master merge conflicts

debug_backend package: removed everything but pygdbmi from the Pipfile

update lock fix debug init
brianignacio5 pushed a commit to brianignacio5/vscode-esp-idf-extension that referenced this issue Mar 25, 2020
@an-dr @brianignacio5
Added a custom Debug Adapter
a8e2b7d 
fix old configs remove build before debug

fix debug adapter unit test

DA python pkgs check (espressif#3)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

Fix/da merge (espressif#4)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* fix debug adapter unit test

* DA python pkgs check (espressif#3)

* read Cmakelists file for project name (VSC-248) (espressif#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (espressif#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (espressif#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* fix merge issues

* log adapter output

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

An dr/feature/debug adapter (espressif#5)

Fix Espressif master merge conflicts

debug_backend package: removed everything but pygdbmi from the Pipfile

update lock fix debug init

prettier ignore py files
brianignacio5 added a commit that referenced this issue Mar 26, 2020
@an-dr @brianignacio5 @pwmb
Added a custom Debug Adapter (VSC-250) (#45)
7178fc8 
* Added a custom Debug Adapter

* fix old configs remove build before debug

* fix debug adapter unit test

* DA python pkgs check (#3)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* Fix/da merge (#4)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* fix debug adapter unit test

* DA python pkgs check (#3)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

* Added a custom Debug Adapter

* fix old configs remove build before debug

* removed outdated extension.test.ts

* fix debug adapter unit test

* removed repeated options

* removed redundant requirements.txt

* made `Upload testing.results.log` always executable

* add adapter python reqs checking

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* fix merge issues

* log adapter output

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* An dr/feature/debug adapter (#5)

Fix Espressif master merge conflicts

* debug_backend package: removed everything but pygdbmi from the Pipfile

* Fix/da conflict (#6)

* read Cmakelists file for project name (VSC-248) (#43)

read build project_description json file for project name

* Feature/localization kv val (VSC-226) (VSC-246) (#41)

* add gulp i18n validation and src missing key log

* rm unused i18n field, add unknown field (#48)

* v0.1.4

Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>

* Run prettier

* yarn audit fix

Co-authored-by: brian@espressif.com <brian@espressif.com>
Co-authored-by: Brian A. Ignacio <brianignacio5@gmail.com>
Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>
pwmb added a commit that referenced this issue May 18, 2020
@pwmb
Merge pull request #4 from espressif/master
4222336 
merge from GH master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Stale PR or Issue vscode related problem This issue is related to the bug/ behaviours of the vscode and not the extension itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@projectgus @Devenda @pwmb