Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis.rst, codingday #1565

Merged
merged 23 commits into from
Oct 26, 2017
Merged

analysis.rst, codingday #1565

merged 23 commits into from
Oct 26, 2017

Conversation

davidsean
Copy link
Contributor

@davidsean davidsean commented Oct 25, 2017

Fixes #1494

Description of changes:

  • moved/wrote descriptions to docstring
  • fixed a few bugs
  • flagged (still) unsupported methods
  • need to delete methods which will never be supported
  • unit test for chain routines (calc_rg, calc_re, calc_rh)

PR Checklist

  • Tests?
    • Interface
    • Core
  • Docs?

@codecov
Copy link

codecov bot commented Oct 25, 2017

Codecov Report

Merging #1565 into python will decrease coverage by 9.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           python    #1565      +/-   ##
==========================================
- Coverage   43.99%   34.76%   -9.23%     
==========================================
  Files         375      269     -106     
  Lines       29014    15057   -13957     
  Branches     5425     2790    -2635     
==========================================
- Hits        12765     5235    -7530     
+ Misses      16224     9790    -6434     
- Partials       25       32       +7
Impacted Files Coverage Δ
src/core/minimize_energy.cpp 0% <0%> (-100%) ⬇️
src/core/lattice.hpp 0% <0%> (-100%) ⬇️
src/core/mmm-common.cpp 0% <0%> (-100%) ⬇️
src/core/shapes/Sphere.hpp 0% <0%> (-100%) ⬇️
src/core/utils.cpp 0% <0%> (-100%) ⬇️
src/script_interface/shapes/Wall.hpp 0% <0%> (-100%) ⬇️
src/script_interface/shapes/Sphere.hpp 0% <0%> (-100%) ⬇️
src/core/observables/MagneticDipoleMoment.hpp 0% <0%> (-100%) ⬇️
src/core/correlators/Correlator.hpp 0% <0%> (-100%) ⬇️
src/core/constraints/HomogeneousMagneticField.cpp 0% <0%> (-100%) ⬇️
... and 270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad1efb...81f2626. Read the comment docs.

@fweik fweik merged commit 8819f5c into espressomd:python Oct 26, 2017
@davidsean davidsean deleted the test branch November 24, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis routines not documented (rdf, ...)
2 participants