Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some analysis that has no test and py interface #1640

Merged
merged 7 commits into from
Nov 22, 2017

Conversation

RudolfWeeber
Copy link
Contributor

Part of what was announced on the mailing list.

Those analysis routines without a Py interface that are either very specific to a project or entirely undocumented and untested.

Each one has a single commit, so partially reverting is possible.

Closes: #271 analysis diffusion_profile
Closes: #258 analyze ..._mol
Closes: #257 analyze cel_gpb
Closes: #248 analyze mol
Closes: #247 analyze lipid_orient_order
Closes: #246 analyze get_lipid_oriends
Closes: #244 analyze bilayer
Closes: #243 analyze modes2d
Closes: #264 analyze necklace

@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

Merging #1640 into python will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           python    #1640      +/-   ##
==========================================
+ Coverage   47.51%   48.56%   +1.04%     
==========================================
  Files         393      391       -2     
  Lines       29252    28637     -615     
  Branches     5454     5293     -161     
==========================================
+ Hits        13900    13908       +8     
+ Misses      15328    14705     -623     
  Partials       24       24
Impacted Files Coverage Δ
src/core/statistics.cpp 30.16% <ø> (+4.6%) ⬆️
src/core/virtual_sites_com.cpp 4.47% <ø> (+2.03%) ⬆️
src/core/statistics_cluster.cpp 0% <ø> (ø) ⬆️
src/core/statistics.hpp 87.5% <ø> (ø) ⬆️
src/core/p3m.cpp 83.18% <0%> (+0.78%) ⬆️
src/core/topology.hpp 100% <0%> (+50%) ⬆️
src/core/virtual_sites.hpp 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8687ce4...c1a387c. Read the comment docs.

@fweik fweik added this to the Espresso 4.0 milestone Nov 22, 2017
@fweik fweik merged commit 124b16b into espressomd:python Nov 22, 2017
ashreyaj pushed a commit to ashreyaj/espresso that referenced this pull request Aug 9, 2018
Remove some analysis that has no test and py interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants