Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant CI jobs #2834

Merged
merged 5 commits into from May 14, 2019
Merged

Remove redundant CI jobs #2834

merged 5 commits into from May 14, 2019

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 14, 2019

First PR for #2694

Description of changes:

@jngrad jngrad added the DevOps label May 14, 2019
@jngrad jngrad added this to the Espresso 4.1 milestone May 14, 2019
@mkuron
Copy link
Member

mkuron commented May 14, 2019

Please check https://hub.docker.com/u/espressomd. These images are used by Travis. All images except for espresso-ubuntu and espresso-ubuntu-python3 should be deleted. And these two seem to have not been automatically rebuilt in almost a year for some reason.

@jngrad
Copy link
Member Author

jngrad commented May 14, 2019

@mkuron thanks for the link, the Dockerfile there really needs an update. The .travis.yml here too.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #2834 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2834    +/-   ##
=======================================
- Coverage      83%     82%    -1%     
=======================================
  Files         517     514     -3     
  Lines       26895   26850    -45     
=======================================
- Hits        22374   22210   -164     
- Misses       4521    4640   +119
Impacted Files Coverage Δ
src/core/galilei.cpp 0% <0%> (-92%) ⬇️
src/core/errorhandling.cpp 55% <0%> (-30%) ⬇️
src/core/communication.cpp 73% <0%> (-22%) ⬇️
..._interface/accumulators/AutoUpdateAccumulators.hpp 87% <0%> (-13%) ⬇️
src/core/MpiCallbacks.hpp 95% <0%> (-1%) ⬇️
src/core/integrate.cpp 73% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (-1%) ⬇️
...ore/grid_based_algorithms/lb_particle_coupling.cpp 91% <0%> (-1%) ⬇️
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️
src/core/unit_tests/MpiCallbacks_test.cpp 100% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25c40a...c4763d9. Read the comment docs.

@jngrad
Copy link
Member Author

jngrad commented May 14, 2019

The remaining Docker containers and CI jobs will be converted to Python 3 later (hopefully for the next ES meeting). Merging this now will reduce the load on CI for new PRs.

@jngrad jngrad requested a review from fweik May 14, 2019 16:39
@fweik
Copy link
Contributor

fweik commented May 14, 2019

bors r+

bors bot added a commit that referenced this pull request May 14, 2019
2834: Remove redundant CI jobs r=fweik a=jngrad

First PR for #2694

Description of changes:
- updated MacOS X jobs and some Ubuntu 18 jobs to Python3
- removed redundant Python2 jobs: 2 in GitLab CI and 1 in Travis CI
- there should be no difference in coverage (espressomd/docker#78)

Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented May 14, 2019

Build succeeded

@bors bors bot merged commit c4763d9 into espressomd:python May 14, 2019
@jngrad jngrad deleted the jobs-1 branch January 18, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants