Fix bytestring issues in Python3 #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2898 +/- ##
======================================
- Coverage 82% 82% -1%
======================================
Files 519 519
Lines 26958 26958
======================================
- Hits 22312 22310 -2
- Misses 4646 4648 +2
Continue to review full report at Codecov.
|
RudolfWeeber
approved these changes
Jun 12, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 12, 2019
2898: Fix bytestring issues in Python3 r=RudolfWeeber a=jngrad Fixes #2709 Description of changes: - use `to_str()` whenever the core returns a string in P3M, DipolarP3M, MMM1D - use `to_str()` when formatting Python exception messages based on error messages from the core Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2709
Description of changes:
to_str()whenever the core returns a string in P3M, DipolarP3M, MMM1Dto_str()when formatting Python exception messages based on error messages from the core