Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed that build failed if h5md is not present #338

Merged
merged 3 commits into from
Jul 3, 2015

Conversation

dschwoerer
Copy link
Contributor

If h5md is not present and configure is run with:
./configure --with-h5md=no
The build failed as the header file was still tried to be included.

@dschwoerer
Copy link
Contributor Author

The fix for issue #337 allows a sd_radius of -1
Other negative values are not allowed, in order to avoid to accidentally set a negative timestep.

@dschwoerer
Copy link
Contributor Author

I didn't change anything in the lb part, therefore i think it should be save to merge anyway.

@fweik
Copy link
Contributor

fweik commented Jun 16, 2015

Have you tried --without-h5md ?

@dschwoerer
Copy link
Contributor Author

I tried
./configure --with-h5md=no
Without that, configure failed.
With that, configure succeeded, but the build failed, as the #include h5md.h was outside the #ifdef, and therefore the compiler looked for it, irrespective of the configuration.

fweik added a commit that referenced this pull request Jul 3, 2015
fixed that build failed if h5md is not present
@fweik fweik merged commit 52d038e into espressomd:master Jul 3, 2015
@fweik fweik mentioned this pull request Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants