Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE Heart Rate Monitor improvements #1229

Merged
merged 10 commits into from Jan 7, 2022
Merged

BLE Heart Rate Monitor improvements #1229

merged 10 commits into from Jan 7, 2022

Conversation

halemmerich
Copy link
Collaborator

  • Make overriding the HRM event optional
  • Emit BTHRM event for external sensor
  • Add recorder app plugin

@gfwilliams
Copy link
Member

Looks great - thanks! However looking at https://github.com/espruino/BangleApps/pull/1229/files it seems you've got some .orig merge conflict files in there by accident - please could you remove those?

@halemmerich
Copy link
Collaborator Author

Fixed :) Merge #1228 first, as this is based on the other branch.

@gfwilliams
Copy link
Member

Thanks!

@gfwilliams gfwilliams merged commit 53d7103 into espruino:master Jan 7, 2022
This was referenced Jan 7, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@halemmerich @gfwilliams