Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widclose: remove widget if Bangle.CLOCK is set after loading the widget #1865

Closed
wants to merge 1 commit into from

Conversation

rigrig
Copy link
Contributor

@rigrig rigrig commented May 22, 2022

No description provided.

@gfwilliams
Copy link
Member

Which clocks is this a problem for? Because I think really we just need to fix those clocks. There are a bunch of other widgets that rely on CLOCK being set at the start (like chrono, clock widget, etc) so we should really just try and fix the broken clocks rather than trying to work around this in each widget

@rigrig
Copy link
Contributor Author

rigrig commented May 23, 2022

Well, clocks using ClockFace (oops), this PR fixes that, but I figured I would try and mitigate it on the widget side as well.

But you're right: we should just fix clocks, and this only hides the problem.

@rigrig rigrig closed this May 23, 2022
@rigrig rigrig deleted the widclose-remove branch July 29, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants