Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew fixes and translation #248

Closed
wants to merge 1 commit into from
Closed

Conversation

yarons
Copy link

@yarons yarons commented Apr 8, 2020

Hoping there will be RTL and font support soon.

If there's any way I can check it before merging it would be super.

Hoping there will be RTL and font support soon.
@MaBecker
Copy link
Contributor

MaBecker commented Apr 8, 2020

Thanks, at the moment there is no font to display the chars you used. that's the reason for en_IL.

Can you please check en_IL, to be sure it has correct entries.

@gfwilliams
Copy link
Member

Thanks! But I'm afraid this is unlikely to work with the current fonts. You can see what we have available at https://www.espruino.com/Fonts#bitmap-font

You can test with the instructions at: https://www.espruino.com/Bangle.js+App+Loader

If there was a font with these characters, would it work for you? https://en.wikipedia.org/wiki/ISO/IEC_8859-8

@yarons
Copy link
Author

yarons commented Apr 9, 2020

@MaBecker Sadly I've added the en_IL fixes as well but it's pretty basic, in Israel we're using Celsius, not Farnheit and I'll probably create an additional pull request to display the full date the right way.

@gfwilliams Thank you for all the info, I'm looking for a good bitmap editor to try and possibly design some bitmap Hebrew fonts myself.

Regarding ISO8859-8 it might do the trick but I think ISO8859-8-I is even better and from my experience Windows-1255 or CP1255 is the best in that case because it has a relatively the widest support range in addition to the word reversing algorithms (Hebrew is written from right to left).

Thank you very much!

@MaBecker
Copy link
Contributor

MaBecker commented Apr 9, 2020

May be this Espruino Bitmap Font Converter can help, to create the wanted font.

http://ebfc.mattbrailsford.com/

@yarons
Copy link
Author

yarons commented Apr 9, 2020

Yes, it looks awesome but I need to design the fonts first 😄 (draw the bitmap and put the character in the right place).

@gfwilliams
Copy link
Member

Closing this for now as it won't work, to try and de-clutter the repo. I changed the temperature in en_IL though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants