Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move minify setting into expandable area, and warn #2709

Merged
merged 2 commits into from Apr 28, 2023

Conversation

bobrippling
Copy link
Collaborator

This moves the minify option to an expandable advanced section, and changes the warning ("may" -> "will"). See #2562 for more details.

Deployed to my gh pages if you want a preview.

This moves the minify option to an expandable advanced section, and changes the warning ("may" -> "will")

See espruino#2562 for more details.
@gfwilliams
Copy link
Member

Thanks! Looks good, but maybe you could move the 'translations' setting above the 'Advanced Options'? it's a bit odd having it in the middle.

Also, I really appreciate the link for testing - it makes life so much easier!

@bobrippling
Copy link
Collaborator Author

Yeah that looks much nicer - gh pages updated too if you wanted to re-check (maybe a bit of a gap (<br>?) between "advanced options" and the "default settings" button?)

@gfwilliams
Copy link
Member

Looks great, thanks! Actually I think I'll move the 'Default Settings' button into 'Advanced' then it's less likely to get accidentally clicked!

@gfwilliams gfwilliams merged commit 7fb3bd7 into espruino:master Apr 28, 2023
1 check passed
@bobrippling
Copy link
Collaborator Author

Ah nice idea, and thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants