Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: add a simple 12-hr clock #70

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

ryzokuken
Copy link
Contributor

/cc @gfwilliams wdyt?

@ryzokuken
Copy link
Contributor Author

ryzokuken commented Dec 19, 2019

I wonder if a better option here would be to add a setting called "12-hour clock" and expect clock devs to handle that (then I'd remove the new app and just add a condition in the main sclock).

@gfwilliams gfwilliams mentioned this pull request Jan 6, 2020
@gfwilliams
Copy link
Member

Looks good - thanks!

I'm in two minds about the 24 hour thing - in stuff like this it makes a lot of sense, but then I'm also a big fan of keeping stuff as simple as possible.

I'll merge this now and I've filed an issue on #76

@gfwilliams gfwilliams merged commit 3ab56c7 into espruino:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants